Merge "Add test to confirm -L flag for cc deps in rust" into main (497a6df3) · Commits · e / os / android_build_soong

rust/library_test.go

+59 −0

Original line number	Diff line number	Diff line
		@@ -196,6 +196,65 @@ func TestStaticLibraryLinkage(t *testing.T) {
		}
		}

		func TestNativeDependencyOfRlib(t *testing.T) {
		ctx := testRust(t, `
		rust_ffi_static {
		name: "libffi_static",
		crate_name: "ffi_static",
		rlibs: ["librust_rlib"],
		srcs: ["foo.rs"],
		}
		rust_library_rlib {
		name: "librust_rlib",
		crate_name: "rust_rlib",
		srcs: ["foo.rs"],
		shared_libs: ["shared_cc_dep"],
		static_libs: ["static_cc_dep"],
		}
		cc_library_shared {
		name: "shared_cc_dep",
		srcs: ["foo.cpp"],
		}
		cc_library_static {
		name: "static_cc_dep",
		srcs: ["foo.cpp"],
		}
		`)

		rustRlibRlibStd := ctx.ModuleForTests("librust_rlib", "android_arm64_armv8-a_rlib_rlib-std")
		rustRlibDylibStd := ctx.ModuleForTests("librust_rlib", "android_arm64_armv8-a_rlib_dylib-std")
		ffiStatic := ctx.ModuleForTests("libffi_static", "android_arm64_armv8-a_static")

		modules := []android.TestingModule{
		rustRlibRlibStd,
		rustRlibDylibStd,
		ffiStatic,
		}

		// librust_rlib specifies -L flag to cc deps output directory on rustc command
		// and re-export the cc deps to rdep libffi_static
		// When building rlib crate, rustc doesn't link the native libraries
		// The build system assumes the cc deps will be at the final linkage (either a shared library or binary)
		// Hence, these flags are no-op
		// TODO: We could consider removing these flags
		for _, module := range modules {
		if !strings.Contains(module.Rule("rustc").Args["libFlags"],
		"-L out/soong/.intermediates/shared_cc_dep/android_arm64_armv8-a_shared/") {
		t.Errorf(
		"missing -L flag for shared_cc_dep, rustcFlags: %#v",
		rustRlibRlibStd.Rule("rustc").Args["libFlags"],
		)
		}
		if !strings.Contains(module.Rule("rustc").Args["libFlags"],
		"-L out/soong/.intermediates/static_cc_dep/android_arm64_armv8-a_static/") {
		t.Errorf(
		"missing -L flag for static_cc_dep, rustcFlags: %#v",
		rustRlibRlibStd.Rule("rustc").Args["libFlags"],
		)
		}
		}
		}

		// Test that variants pull in the right type of rustlib autodep
		func TestAutoDeps(t *testing.T) {