Commit 46c46cca authored Jan 13, 2020 by Matthew Maurer

rust: Do not pass -C prefer-dynamic for cdylib

cdylib targets cannot currently dynamically link to Rust crates, so this
flag was not actually doing anything, and in conjunction with -C lto
which we *do* want on for this target, causes a hard error on
rustc-1.40.0.

Bug: 147438124
Test: Build a rust_library module, this implicitly tries to build cdylib
Change-Id: I828b3e6bae7c58f4081db3e73009b443a382a296

parent 22cef966

rust/library.go

+1 −1

Original line number	Diff line number	Diff line
		@@ -338,7 +338,7 @@ func (library *libraryDecorator) compile(ctx ModuleContext, flags Flags, deps Pa

		flags.RustFlags = append(flags.RustFlags, deps.depFlags...)

		if library.dylib() \|\| library.shared() {
		if library.dylib() {
		// We need prefer-dynamic for now to avoid linking in the static stdlib. See:
		// https://github.com/rust-lang/rust/issues/19680
		// https://github.com/rust-lang/rust/issues/34909