Revert "Use protoc-gen-javalite for java lite protos" (37a07b17) · Commits · e / os / android_build_soong

android/config.go

+0 −4

Original line number	Diff line number	Diff line
		@@ -351,10 +351,6 @@ func (c *config) BlueprintToolLocation() string {

		var _ bootstrap.ConfigBlueprintToolLocation = (*config)(nil)

		func (c *config) HostToolPath(ctx PathContext, tool string) Path {
		return PathForOutput(ctx, "host", c.PrebuiltOS(), "bin", tool)
		}

		// HostSystemTool looks for non-hermetic tools from the system we're running on.
		// Generally shouldn't be used, but useful to find the XCode SDK, etc.
		func (c *config) HostSystemTool(name string) string {

java/builder.go

+0 −1

Original line number	Diff line number	Diff line
		@@ -161,7 +161,6 @@ type javaBuilderFlags struct {
		kotlincClasspath classpath

		protoFlags []string
		protoDeps android.Paths
		protoOutTypeFlag string // The flag itself: --java_out
		protoOutParams string // Parameters to that flag: --java_out=$protoOutParams:$outDir
		protoRoot bool

java/proto.go

+9 −12

Original line number	Diff line number	Diff line
		@@ -59,7 +59,6 @@ func genProto(ctx android.ModuleContext, protoFile android.Path, flags javaBuild
		Description: "protoc " + protoFile.Rel(),
		Output: srcJarFile,
		Input: protoFile,
		Implicits: flags.protoDeps,
		Args: map[string]string{
		"protoBase": protoBase,
		"protoOut": flags.protoOutTypeFlag,
		@@ -94,16 +93,14 @@ func protoDeps(ctx android.BottomUpMutatorContext, p *android.ProtoProperties) {
		func protoFlags(ctx android.ModuleContext, j CompilerProperties, p android.ProtoProperties,
		flags javaBuilderFlags) javaBuilderFlags {

		var plugin string

		switch String(p.Proto.Type) {
		case "micro":
		flags.protoOutTypeFlag = "--javamicro_out"
		case "nano":
		flags.protoOutTypeFlag = "--javanano_out"
		case "lite":
		plugin = "protoc-gen-javalite"
		flags.protoOutTypeFlag = "--javalite_out"
		flags.protoOutTypeFlag = "--java_out"
		flags.protoOutParams = "lite"
		case "full", "":
		flags.protoOutTypeFlag = "--java_out"
		default:
		@@ -111,15 +108,15 @@ func protoFlags(ctx android.ModuleContext, j CompilerProperties, p android.Pro
		String(p.Proto.Type))
		}

		flags.protoOutParams = strings.Join(j.Proto.Output_params, ",")
		if len(j.Proto.Output_params) > 0 {
		if flags.protoOutParams != "" {
		flags.protoOutParams += ","
		}
		flags.protoOutParams += strings.Join(j.Proto.Output_params, ",")
		}

		flags.protoFlags = android.ProtoFlags(ctx, p)
		flags.protoRoot = android.ProtoCanonicalPathFromRoot(ctx, p)

		if plugin != "" {
		path := ctx.Config().HostToolPath(ctx, plugin)
		flags.protoDeps = append(flags.protoDeps, path)
		flags.protoFlags = append(flags.protoFlags, "--plugin="+path.String())
		}

		return flags
		}