Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 33e7f6a0 authored by Patrice Arruda's avatar Patrice Arruda
Browse files

Remove unnecessary break and default statements in metrics.go file. 

break and default statements are not needed inside of a switch
statement.

Bug: b/173028918
Test: USE_BAZEL m nothing
Change-Id: I14aa8cbae3a9b3c859f147c5134600f1e75c6a89
parent b7cf9ba1

ui/metrics/metrics.go

+0 −12
Original line number Diff line number Diff line
@@ -54,19 +54,14 @@ func (m *Metrics) SetTimeMetrics(perf soong_metrics_proto.PerfInfo) { 
	switch perf.GetName() {

	case RunKati:

		m.metrics.KatiRuns = append(m.metrics.KatiRuns, &perf)

		break

	case RunSoong:

		m.metrics.SoongRuns = append(m.metrics.SoongRuns, &perf)

		break

	case RunBazel:

		m.metrics.BazelRuns = append(m.metrics.BazelRuns, &perf)

	case PrimaryNinja:

		m.metrics.NinjaRuns = append(m.metrics.NinjaRuns, &perf)

		break

	case Total:

		m.metrics.Total = &perf

	default:

		// ignored

	}

}
@@ -83,13 +78,10 @@ func (m *Metrics) SetMetadataMetrics(metadata map[string]string) { 
		switch k {

		case "BUILD_ID":

			m.metrics.BuildId = proto.String(v)

			break

		case "PLATFORM_VERSION_CODENAME":

			m.metrics.PlatformVersionCodename = proto.String(v)

			break

		case "TARGET_PRODUCT":

			m.metrics.TargetProduct = proto.String(v)

			break

		case "TARGET_BUILD_VARIANT":

			switch v {

			case "user":
@@ -98,8 +90,6 @@ func (m *Metrics) SetMetadataMetrics(metadata map[string]string) { 
				m.metrics.TargetBuildVariant = soong_metrics_proto.MetricsBase_USERDEBUG.Enum()

			case "eng":

				m.metrics.TargetBuildVariant = soong_metrics_proto.MetricsBase_ENG.Enum()

			default:

				// ignored

			}

		case "TARGET_ARCH":

			m.metrics.TargetArch = m.getArch(v)
@@ -121,8 +111,6 @@ func (m *Metrics) SetMetadataMetrics(metadata map[string]string) { 
			m.metrics.HostCross_2NdArch = proto.String(v)

		case "OUT_DIR":

			m.metrics.OutDir = proto.String(v)

		default:

			// ignored

		}

	}

}