Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 26bdac55 authored by Cole Faust's avatar Cole Faust
Browse files

Add partition size check to boot partitions 

Since android devices are partitioned at the factory and the partitions
can't be resized aftwards, make allows you to specify that partition
size and asserts that the contents don't exceed it. Soong also needed
this check.

Bug: 377562951
Test: Manually modified BOARD_BOOTIMAGE_PARTITION_SIZE to test the warning and error
Change-Id: I2368b350fb99c4055b14baa84b4964012f4934ef
parent 1c9c335a

filesystem/bootimg.go

+8 −0
Original line number Diff line number Diff line
@@ -67,6 +67,10 @@ type BootimgProperties struct { 
	// and `header_version` is greater than or equal to 4.

	Bootconfig *string `android:"arch_variant,path"`



	// The size of the partition on the device. It will be a build error if this built partition

	// image exceeds this size.

	Partition_size *int64



	// When set to true, sign the image with avbtool. Default is false.

	Use_avb *bool
@@ -216,6 +220,10 @@ func (b *bootimg) buildBootImage(ctx android.ModuleContext, vendor bool) android 
	}

	cmd.FlagWithOutput(flag, output)



	if b.properties.Partition_size != nil {

		assertMaxImageSize(builder, output, *b.properties.Partition_size, proptools.Bool(b.properties.Use_avb))

	}



	builder.Build("build_bootimg", fmt.Sprintf("Creating %s", b.BaseModuleName()))

	return output

}

filesystem/filesystem.go

+23 −0
Original line number Diff line number Diff line
@@ -926,3 +926,26 @@ func (f *filesystem) getLibsForLinkerConfig(ctx android.ModuleContext) ([]androi 


	return provideModules, requireModules

}



// Checks that the given file doesn't exceed the given size, and will also print a warning

// if it's nearing the maximum size. Equivalent to assert-max-image-size in make:

// https://cs.android.com/android/platform/superproject/main/+/main:build/make/core/definitions.mk;l=3455;drc=993c4de29a02a6accd60ceaaee153307e1a18d10

func assertMaxImageSize(builder *android.RuleBuilder, image android.Path, maxSize int64, addAvbLater bool) {

	if addAvbLater {

		// The value 69632 is derived from MAX_VBMETA_SIZE + MAX_FOOTER_SIZE in avbtool.

		// Logic copied from make:

		// https://cs.android.com/android/platform/superproject/main/+/main:build/make/core/Makefile;l=228;drc=a6a0007ef24e16c0b79f439beac4a118416717e6

		maxSize -= 69632

	}

	cmd := builder.Command()

	cmd.Textf(`file="%s"; maxsize="%d";`+

		`total=$(stat -c "%%s" "$file" | tr -d '\n');`+

		`if [ "$total" -gt "$maxsize" ]; then `+

		`  echo "error: $file too large ($total > $maxsize)";`+

		`  false;`+

		`elif [ "$total" -gt $((maxsize - 32768)) ]; then `+

		`  echo "WARNING: $file approaching size limit ($total now; limit $maxsize)";`+

		`fi`,

		image, maxSize)

	cmd.Implicit(image)

}

fsgen/boot_imgs.go

+10 −0
Original line number Diff line number Diff line
@@ -36,6 +36,15 @@ func createBootImage(ctx android.LoadHookContext) bool { 
		},

	)



	var partitionSize *int64

	if partitionVariables.BoardBootimagePartitionSize != "" {

		parsed, err := strconv.ParseInt(partitionVariables.BoardBootimagePartitionSize, 10, 64)

		if err != nil {

			panic(fmt.Sprintf("BOARD_BOOTIMAGE_PARTITION_SIZE must be an int, got %s", partitionVariables.BoardBootimagePartitionSize))

		}

		partitionSize = &parsed

	}



	bootImageName := generatedModuleNameForPartition(ctx.Config(), "boot")



	ctx.CreateModule(
@@ -43,6 +52,7 @@ func createBootImage(ctx android.LoadHookContext) bool { 
		&filesystem.BootimgProperties{

			Kernel_prebuilt: proptools.StringPtr(":" + kernelFilegroupName),

			Header_version:  proptools.StringPtr(partitionVariables.BoardBootHeaderVersion),

			Partition_size:  partitionSize,

		},

		&struct {

			Name *string