Loading sdk/update.go +7 −5 Original line number Diff line number Diff line Loading @@ -1118,12 +1118,14 @@ func (s *snapshotBuilder) AddPrebuiltModule(member android.SdkMember, moduleType // Since module sdks are generated from release branches and dropped to development // branches, there might be a visibility skew between the sources and prebuilts // of a specific module. // To reconcile this potential skew, change the visibility to public // To reconcile this potential skew, change the visibility to public. // // This is safe for (1) since these are stub libraries. // This is ok for (2) since these are host and test exports and are intended for // ART development. // TODO (b/361303067): This can be removed if ART uses full manifests. // This means dependencies can bypass visibility restrictions when prebuilts are used, so we rely // on source builds in CI to check them. // // TODO (b/361303067): This special case for category (2) can be removed if existing usages // of host/test prebuilts of modules like conscrypt,tzdata,i18n are switched to source builds. // It will also require ART switching to full manifests. m.AddProperty("visibility", []string{"//visibility:public"}) } Loading Loading
sdk/update.go +7 −5 Original line number Diff line number Diff line Loading @@ -1118,12 +1118,14 @@ func (s *snapshotBuilder) AddPrebuiltModule(member android.SdkMember, moduleType // Since module sdks are generated from release branches and dropped to development // branches, there might be a visibility skew between the sources and prebuilts // of a specific module. // To reconcile this potential skew, change the visibility to public // To reconcile this potential skew, change the visibility to public. // // This is safe for (1) since these are stub libraries. // This is ok for (2) since these are host and test exports and are intended for // ART development. // TODO (b/361303067): This can be removed if ART uses full manifests. // This means dependencies can bypass visibility restrictions when prebuilts are used, so we rely // on source builds in CI to check them. // // TODO (b/361303067): This special case for category (2) can be removed if existing usages // of host/test prebuilts of modules like conscrypt,tzdata,i18n are switched to source builds. // It will also require ART switching to full manifests. m.AddProperty("visibility", []string{"//visibility:public"}) } Loading