Commit 1e79844f authored Nov 15, 2018 by Evgenii Stepanov

Apply HWASan to libc-in-recovery.

HWASan is disabled in recovery strictly for code size, not for
correctness. With this change, HWASan binaries and libraries can be
used in recovery.

The real reason is the make build system which has no idea of the big
picture, and makes it hard to disable HWASan in _all_ recovery modules
recursively. A few static libraries have sneaked in.

Bug: 119582521
Test: sideload an OTA onto a hwasan device
Change-Id: I6536cc7bf5bfb37f939b585545a23c2068fbd47f

parent 2fcac47e

cc/sanitize.go

+2 −1

Original line number	Diff line number	Diff line
		@@ -299,7 +299,8 @@ func (sanitize *sanitize) begin(ctx BaseModuleContext) {
		}

		// HWASan ramdisk (which is built from recovery) goes over some bootloader limit.
		if ctx.inRecovery() {
		// Keep libc instrumented so that recovery can run hwasan-instrumented code if necessary.
		if ctx.inRecovery() && !strings.HasPrefix(ctx.ModuleDir(), "bionic/libc") {
		s.Hwaddress = nil
		}