Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1aeb049a authored by Colin Cross's avatar Colin Cross
Browse files

Panic if logging is attempted after Close 

Attempt to catch places where logs are truncated by panicing if
logging is attempted after Close.

Test: m nothing
Change-Id: If670f20d08832ed65b63af5589b548e9815f2f0d
parent b98d3bcf

ui/logger/logger.go

+5 −1
Original line number Diff line number Diff line
@@ -180,12 +180,16 @@ func (s *stdLogger) SetOutput(path string) *stdLogger { 
	return s

}



type panicWriter struct{}



func (panicWriter) Write([]byte) (int, error) { panic("write to panicWriter") }



// Close disables logging to the file and closes the file handle.

func (s *stdLogger) Close() {

	s.mutex.Lock()

	defer s.mutex.Unlock()

	if s.file != nil {

		s.fileLogger.SetOutput(ioutil.Discard)

		s.fileLogger.SetOutput(panicWriter{})

		s.file.Close()

		s.file = nil

	}