Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f0196016 authored by Kiyoung Kim's avatar Kiyoung Kim
Browse files

Add a new variable for deprecating VNDK 

Add a new flag variable for deprecating VNDK. This variable should be
passed to Soong, so it can change behavior based on the flag.

Bug: 290157355
Test: build succeeded with KEEP_VNDK=false
Change-Id: I3a9d1041411ad24ff42f76506a8f929e364b868d
parent 76d1e380

core/config.mk

+3 −0
Original line number Diff line number Diff line
@@ -778,6 +778,9 @@ $(KATI_obsolete_var $(foreach req,$(requirements),$(req)_OVERRIDE) \ 


requirements :=



# Set default value of KEEP_VNDK.

KEEP_VNDK ?= true



# BOARD_PROPERTY_OVERRIDES_SPLIT_ENABLED can be true only if early-mount of

# partitions is supported. But the early-mount must be supported for full

# treble products, and so BOARD_PROPERTY_OVERRIDES_SPLIT_ENABLED should be set

core/main.mk

+6 −0
Original line number Diff line number Diff line
@@ -218,6 +218,12 @@ ifdef BOARD_VNDK_VERSION 
  else

    ADDITIONAL_VENDOR_PROPERTIES := ro.vndk.version=$(BOARD_VNDK_VERSION)

  endif



  # TODO(b/290159430): ro.vndk.deprecate is a temporal variable for deprecating VNDK.

  # This variable will be removed once ro.vndk.version can be removed.

  ifneq ($(KEEP_VNDK),true)

    ADDITIONAL_SYSTEM_PROPERTIES += ro.vndk.deprecate=true

  endif

endif



# Add cpu properties for bionic and ART.

core/soong_config.mk

+2 −0
Original line number Diff line number Diff line
@@ -318,6 +318,8 @@ $(call add_json_list, BuildVersionTags, $(BUILD_VERSION_TAGS)) 
$(call add_json_str, ReleaseVersion,    $(_RELEASE_VERSION))

$(call add_json_list, ReleaseAconfigValueSets,    $(RELEASE_ACONFIG_VALUE_SETS))



$(call add_json_bool, KeepVndk, $(filter true,$(KEEP_VNDK)))



$(call json_end)



$(file >$(SOONG_VARIABLES).tmp,$(json_contents))