Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ee99ddf9 authored by Yi Kong's avatar Yi Kong
Browse files

Rename modulesAddedWall to modulesWarningsAllowed 

MODULES_ADDED_WALL is deceiving and it actually meant which modules are
allowed to have warnings (do not automatically append -Werror flag).

Test: presubmit
Bug: 233183337
Change-Id: Ia2eb972d3d76ba245840f9872cbcc66d2894dab3
parent 9327b9cb

core/Makefile

+2 −2
Original line number Diff line number Diff line
@@ -694,8 +694,8 @@ $(WALL_WERROR): 
	@rm -f $@

	echo "# Modules using -Wno-error" >> $@

	for m in $(sort $(SOONG_MODULES_USING_WNO_ERROR) $(MODULES_USING_WNO_ERROR)); do echo $$m >> $@; done

	echo "# Modules added default -Wall" >> $@

	for m in $(sort $(SOONG_MODULES_ADDED_WALL) $(MODULES_ADDED_WALL)); do echo $$m >> $@; done

	echo "# Modules that allow warnings" >> $@

	for m in $(sort $(SOONG_MODULES_WARNINGS_ALLOWED) $(MODULES_WARNINGS_ALLOWED)); do echo $$m >> $@; done



$(call declare-0p-target,$(WALL_WERROR))

core/binary.mk

+1 −1
Original line number Diff line number Diff line
@@ -1506,7 +1506,7 @@ ifneq (HEADER_LIBRARIES,$(LOCAL_MODULE_CLASS)) 
        ifeq (,$(strip $(call find_warning_allowed_projects,$(LOCAL_PATH))))

          my_cflags := -Wall -Werror $(my_cflags)

        else

          $(eval MODULES_ADDED_WALL := $(MODULES_ADDED_WALL) $(LOCAL_MODULE_MAKEFILE):$(LOCAL_MODULE))

          $(eval MODULES_WARNINGS_ALLOWED := $(MODULES_USING_WNO_ERROR) $(LOCAL_MODULE_MAKEFILE):$(LOCAL_MODULE))

          my_cflags := -Wall $(my_cflags)

        endif

      endif