Merge "Disable dtor inlining for clang-tidy"

      my_tidy_flags += -quiet -extra-arg-before=-fno-caret-diagnostics

    endif

    ifneq ($(my_tidy_checks),)

      # We might be using the static analyzer through clang-tidy.

      # https://bugs.llvm.org/show_bug.cgi?id=32914

    ifneq ($(my_tidy_checks),)

      my_tidy_flags += -extra-arg-before=-D__clang_analyzer__

      # A recent change in clang-tidy (r328258) enabled destructor inlining,

      # which appears to cause a number of false positives. Until that's

      # resolved, this turns off the effects of r328258.

      # https://bugs.llvm.org/show_bug.cgi?id=37459

      my_tidy_flags += -extra-arg-before=-Xclang

      my_tidy_flags += -extra-arg-before=-analyzer-config

      my_tidy_flags += -extra-arg-before=-Xclang

      my_tidy_flags += -extra-arg-before=c++-temp-dtor-inlining=false

    endif

  endif

endif