Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e51dccea authored by Treehugger Robot's avatar Treehugger Robot Committed by Gerrit Code Review
Browse files

Merge "Updates merge_target_files soong_zip to use -r instead of -l."

parents 1975c1ba eaf5c1dc
Loading
Loading
Loading
Loading
+0 −23
Original line number Diff line number Diff line
@@ -276,29 +276,6 @@ def Run(args, verbose=None, **kwargs):
  return subprocess.Popen(args, **kwargs)


def RunAndWait(args, verbose=None, **kwargs):
  """Runs the given command waiting for it to complete.

  Args:
    args: The command represented as a list of strings.
    verbose: Whether the commands should be shown. Default to the global
        verbosity if unspecified.
    kwargs: Any additional args to be passed to subprocess.Popen(), such as env,
        stdin, etc. stdout and stderr will default to subprocess.PIPE and
        subprocess.STDOUT respectively unless caller specifies any of them.

  Raises:
    ExternalError: On non-zero exit from the command.
  """
  proc = Run(args, verbose=verbose, **kwargs)
  proc.wait()

  if proc.returncode != 0:
    raise ExternalError(
        "Failed to run command '{}' (exit code {})".format(
            args, proc.returncode))


def RunAndCheckOutput(args, verbose=None, **kwargs):
  """Runs the given command and returns the output.

+2 −2
Original line number Diff line number Diff line
@@ -887,12 +887,12 @@ def create_target_files_archive(output_file, source_dir, temp_dir):
      output_zip,
      '-C',
      source_dir,
      '-l',
      '-r',
      output_target_files_list,
  ]

  logger.info('creating %s', output_file)
  common.RunAndWait(command, verbose=True)
  common.RunAndCheckOutput(command, verbose=True)
  logger.info('finished creating %s', output_file)

  return output_zip