Loading tools/releasetools/common.py +0 −23 Original line number Diff line number Diff line Loading @@ -276,29 +276,6 @@ def Run(args, verbose=None, **kwargs): return subprocess.Popen(args, **kwargs) def RunAndWait(args, verbose=None, **kwargs): """Runs the given command waiting for it to complete. Args: args: The command represented as a list of strings. verbose: Whether the commands should be shown. Default to the global verbosity if unspecified. kwargs: Any additional args to be passed to subprocess.Popen(), such as env, stdin, etc. stdout and stderr will default to subprocess.PIPE and subprocess.STDOUT respectively unless caller specifies any of them. Raises: ExternalError: On non-zero exit from the command. """ proc = Run(args, verbose=verbose, **kwargs) proc.wait() if proc.returncode != 0: raise ExternalError( "Failed to run command '{}' (exit code {})".format( args, proc.returncode)) def RunAndCheckOutput(args, verbose=None, **kwargs): """Runs the given command and returns the output. Loading tools/releasetools/merge_target_files.py +2 −2 Original line number Diff line number Diff line Loading @@ -887,12 +887,12 @@ def create_target_files_archive(output_file, source_dir, temp_dir): output_zip, '-C', source_dir, '-l', '-r', output_target_files_list, ] logger.info('creating %s', output_file) common.RunAndWait(command, verbose=True) common.RunAndCheckOutput(command, verbose=True) logger.info('finished creating %s', output_file) return output_zip Loading Loading
tools/releasetools/common.py +0 −23 Original line number Diff line number Diff line Loading @@ -276,29 +276,6 @@ def Run(args, verbose=None, **kwargs): return subprocess.Popen(args, **kwargs) def RunAndWait(args, verbose=None, **kwargs): """Runs the given command waiting for it to complete. Args: args: The command represented as a list of strings. verbose: Whether the commands should be shown. Default to the global verbosity if unspecified. kwargs: Any additional args to be passed to subprocess.Popen(), such as env, stdin, etc. stdout and stderr will default to subprocess.PIPE and subprocess.STDOUT respectively unless caller specifies any of them. Raises: ExternalError: On non-zero exit from the command. """ proc = Run(args, verbose=verbose, **kwargs) proc.wait() if proc.returncode != 0: raise ExternalError( "Failed to run command '{}' (exit code {})".format( args, proc.returncode)) def RunAndCheckOutput(args, verbose=None, **kwargs): """Runs the given command and returns the output. Loading
tools/releasetools/merge_target_files.py +2 −2 Original line number Diff line number Diff line Loading @@ -887,12 +887,12 @@ def create_target_files_archive(output_file, source_dir, temp_dir): output_zip, '-C', source_dir, '-l', '-r', output_target_files_list, ] logger.info('creating %s', output_file) common.RunAndWait(command, verbose=True) common.RunAndCheckOutput(command, verbose=True) logger.info('finished creating %s', output_file) return output_zip Loading