Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e508169c authored by Ivan Lozano's avatar Ivan Lozano
Browse files

Don't export UBSan minimal runtime symbols. 

When linking in the UBSan minimal runtime, don't export the symbols.
This was resulting in an edge case where symbols were sometimes
undefined at runtime on address sanitized builds if static library
dependencies were integer overflow sanitized.

Bug: 78766744
Test: readelf on libraries show either inclusion of the shared library
or no undefined symbols related to the minimal runtime.
Change-Id: I4382cc72baefd7fa96cd83e8349e82f7b083f5aa
parent d744f8cc

core/config_sanitizers.mk

+1 −0
Original line number Diff line number Diff line
@@ -345,6 +345,7 @@ ifeq ($(LOCAL_IS_HOST_MODULE)$(LOCAL_IS_AUX_MODULE),) 
  ifeq ($(filter STATIC_LIBRARIES,$(LOCAL_MODULE_CLASS)),)

    ifndef LOCAL_SDK_VERSION

      my_static_libraries += $($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_MINIMAL_RUNTIME_LIBRARY)

      my_ldflags += -Wl,--exclude-libs,$($(LOCAL_2ND_ARCH_VAR_PREFIX)UBSAN_MINIMAL_RUNTIME_LIBRARY).a

    endif

  endif

  ifneq ($(filter unsigned-integer-overflow signed-integer-overflow integer,$(my_sanitize)),)