Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit e09359ab authored by Tao Bao's avatar Tao Bao
Browse files

DO NOT MERGE Pass source's info_dict to vendor's releasetools.py. 

When building incremental packages, the info_dict from the source build
should be the one in use. We have done that for most of the partitions
(system and etc.), and should pass that to vendor's script as well.

Also includes the CL in commit aac4ad56
that fixes a bug in commit 6f0b219a.

Bug: 24898607
Change-Id: I4ea6037dad7061e1683661fc4c394fa3a7a7c5cd
(cherry picked from commit 6f0b219a)
parent b16edb5f

tools/releasetools/common.py

+9 −1
Original line number Diff line number Diff line
@@ -59,6 +59,8 @@ class Options(object): 
    self.device_specific = None

    self.extras = {}

    self.info_dict = None

    self.source_info_dict = None

    self.target_info_dict = None

    self.worker_threads = None
@@ -1193,7 +1195,11 @@ class BlockDifference(object): 
    self.path = os.path.join(tmpdir, partition)

    b.Compute(self.path)



    if src is None:

      _, self.device = GetTypeAndDevice("/" + partition, OPTIONS.info_dict)

    else:

      _, self.device = GetTypeAndDevice("/" + partition,

                                        OPTIONS.source_info_dict)



  def WriteScript(self, script, output_zip, progress=None):

    if not self.src:
@@ -1391,6 +1397,8 @@ def MakeRecoveryPatch(input_dir, output_sink, recovery_img, boot_img, 
  output_sink("recovery-from-boot.p", patch)



  try:

    # The following GetTypeAndDevice()s need to use the path in the target

    # info_dict instead of source_info_dict.

    boot_type, boot_device = GetTypeAndDevice("/boot", info_dict)

    recovery_type, recovery_device = GetTypeAndDevice("/recovery", info_dict)

  except KeyError:

tools/releasetools/ota_from_target_files.py

+2 −2
Original line number Diff line number Diff line
@@ -753,7 +753,7 @@ def WriteBlockIncrementalOTAPackage(target_zip, source_zip, output_zip): 
      output_zip=output_zip,

      script=script,

      metadata=metadata,

      info_dict=OPTIONS.info_dict)

      info_dict=OPTIONS.source_info_dict)



  # TODO: Currently this works differently from WriteIncrementalOTAPackage().

  # This function doesn't consider thumbprints when writing
@@ -1153,7 +1153,7 @@ def WriteIncrementalOTAPackage(target_zip, source_zip, output_zip): 
      output_zip=output_zip,

      script=script,

      metadata=metadata,

      info_dict=OPTIONS.info_dict)

      info_dict=OPTIONS.source_info_dict)



  system_diff = FileDifference("system", source_zip, target_zip, output_zip)

  script.Mount("/system", recovery_mount_options)