Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d6d1beb8 authored by Dan Albert's avatar Dan Albert
Browse files

Run ZipFile.testzip() during zipfile tests. 

This still doesn't catch the issue that [1] fixes, but it's probably a
good idea anyway.

[1]: https://android-review.googlesource.com/#/c/143469/

Change-Id: Iaa607ec7450d605b26114bd81ea41a14c6613c0e
parent 088521ef

tools/releasetools/test_common.py

+2 −0
Original line number Diff line number Diff line
@@ -62,6 +62,7 @@ class CommonZipTest(unittest.TestCase): 
      new_stat = os.stat(test_file_name)

      self.assertEqual(int(old_stat.st_mode), int(new_stat.st_mode))

      self.assertEqual(int(old_stat.st_mtime), int(new_stat.st_mtime))

      self.assertIsNone(zip_file.testzip())



      zip_file.close()

      zip_file = zipfile.ZipFile(zip_file_name, "r")
@@ -71,6 +72,7 @@ class CommonZipTest(unittest.TestCase): 
      mode = (info.external_attr >> 16) & 0o777

      self.assertEqual(mode, expected_mode)

      self.assertEqual(zip_file.read(arcname), contents)

      self.assertIsNone(zip_file.testzip())

    finally:

      os.remove(test_file_name)

      os.remove(zip_file_name)