Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c639c787 authored by Raphael Moll's avatar Raphael Moll
Browse files

Lunch: don't use a toolchain that doesn't exist. 

"lunch sdk-eng" on cygwin tries to use a gcc.exe from the
prebuild arm toolchain, but it doesn't exist. This prevents
from setting variables to point on a gcc toolchain if there
is none for the given arch.

Change-Id: I3b72220663687f9fdaacc050899aef00632f2c3c
parent 70a86b0f

core/combo/TARGET_linux-arm.mk

+11 −7
Original line number Diff line number Diff line
@@ -47,6 +47,9 @@ TARGET_TOOLS_PREFIX := \ 
	prebuilt/$(HOST_PREBUILT_TAG)/toolchain/arm-eabi-4.4.3/bin/arm-eabi-

endif



# Only define these if there's actually a gcc in there.

# The gcc toolchain does not exists for windows/cygwin. In this case, do not reference it.

ifneq ($(wildcard $(TARGET_TOOLS_PREFIX)gcc$(HOST_EXECUTABLE_SUFFIX)),)

    TARGET_CC := $(TARGET_TOOLS_PREFIX)gcc$(HOST_EXECUTABLE_SUFFIX)

    TARGET_CXX := $(TARGET_TOOLS_PREFIX)g++$(HOST_EXECUTABLE_SUFFIX)

    TARGET_AR := $(TARGET_TOOLS_PREFIX)ar$(HOST_EXECUTABLE_SUFFIX)
@@ -54,6 +57,7 @@ TARGET_OBJCOPY := $(TARGET_TOOLS_PREFIX)objcopy$(HOST_EXECUTABLE_SUFFIX) 
    TARGET_LD := $(TARGET_TOOLS_PREFIX)ld$(HOST_EXECUTABLE_SUFFIX)

    TARGET_STRIP := $(HOST_OUT_EXECUTABLES)/soslim$(HOST_EXECUTABLE_SUFFIX)

    TARGET_STRIP_COMMAND = $(TARGET_STRIP) --strip --shady --quiet $< --outfile $@

endif



TARGET_NO_UNDEFINED_LDFLAGS := -Wl,--no-undefined

core/dumpvar.mk

+5 −2
Original line number Diff line number Diff line
@@ -8,9 +8,12 @@ ABP:=$(PWD)/$(HOST_OUT_EXECUTABLES) 
ifeq ($(TARGET_SIMULATOR),true)

	ABP:=$(ABP):$(TARGET_OUT_EXECUTABLES)

else

	# Add the toolchain bin dir if it actually exists

	ifneq ($(wildcard $(PWD)/prebuilt/$(HOST_PREBUILT_TAG)/toolchain/arm-eabi-4.4.3/bin),)

		# this should be copied to HOST_OUT_EXECUTABLES instead

		ABP:=$(ABP):$(PWD)/prebuilt/$(HOST_PREBUILT_TAG)/toolchain/arm-eabi-4.4.3/bin

	endif

endif

ANDROID_BUILD_PATHS := $(ABP)

ANDROID_PREBUILTS := prebuilt/$(HOST_PREBUILT_TAG)

envsetup.sh

+12 −3
Original line number Diff line number Diff line
@@ -95,18 +95,27 @@ function setpaths() 
    #                                                                #

    ##################################################################



    # Note: on windows/cygwin, ANDROID_BUILD_PATHS will contain spaces

    # due to "C:\Program Files" being in the path.



    # out with the old

    if [ -n $ANDROID_BUILD_PATHS ] ; then

    if [ -n "$ANDROID_BUILD_PATHS" ] ; then

        export PATH=${PATH/$ANDROID_BUILD_PATHS/}

    fi

    if [ -n $ANDROID_PRE_BUILD_PATHS ] ; then

    if [ -n "$ANDROID_PRE_BUILD_PATHS" ] ; then

        export PATH=${PATH/$ANDROID_PRE_BUILD_PATHS/}

    fi



    # and in with the new

    CODE_REVIEWS=

    prebuiltdir=$(getprebuilt)

    export ANDROID_EABI_TOOLCHAIN=$prebuiltdir/toolchain/arm-eabi-4.4.3/bin

    toolchaindir=toolchain/arm-eabi-4.4.3/bin

    # The gcc toolchain does not exists for windows/cygwin. In this case, do not reference it.

    if [ -d "$prebuiltdir/$toolchaindir" ]; then

        export ANDROID_EABI_TOOLCHAIN=$prebuiltdir/$toolchaindir

    else

        export ANDROID_EABI_TOOLCHAIN=

    fi

    export ANDROID_TOOLCHAIN=$ANDROID_EABI_TOOLCHAIN

    export ANDROID_QTOOLS=$T/development/emulator/qtools

    export ANDROID_BUILD_PATHS=:$(get_build_var ANDROID_BUILD_PATHS):$ANDROID_QTOOLS:$ANDROID_TOOLCHAIN:$ANDROID_EABI_TOOLCHAIN$CODE_REVIEWS