Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit be0b6cee authored by Dan Willemsen's avatar Dan Willemsen
Browse files

Replace $(shell find | sort) with $(sort $(shell find)) 

Kati's find emulator doesn't understand "| sort", so use use the make
function instead so that we can emulate the find commands.

 before: *kati*: shell time (regen): 1.316989 / 187
 after:  *kati*: shell time (regen): 1.249748 / 184

The time has a lot of variance, the important change is the reduction in
number of shell commands. Kati has other issues with some of these (it
doesn't support find's implicit -a), which is why it only goes down by
3. I'll be fixing Kati separately to handle those cases.

Test: diff out/build-aosp_taimen.ninja before&after
Change-Id: I5c8c2993f01a8a6af84963e903a8a0c186a61e82
parent fe34c5b5

core/Makefile

+7 −7
Original line number Diff line number Diff line
@@ -2374,18 +2374,18 @@ OTATOOLS_DEPS := \ 
  system/extras/verity/build_verity_metadata.py \

  system/extras/ext4_utils/mke2fs.conf \

  external/avb/test/data/testkey_rsa4096.pem \

  $(shell find system/update_engine/scripts -name \*.pyc -prune -o -type f -print | sort) \

  $(shell find build/target/product/security -type f -name \*.x509.pem -o -name \*.pk8 -o \

      -name verity_key | sort) \

  $(shell find device $(wildcard vendor) -type f -name \*.pk8 -o -name verifiedboot\* -o \

      -name \*.x509.pem -o -name oem\*.prop | sort)

  $(sort $(shell find system/update_engine/scripts -name \*.pyc -prune -o -type f -print)) \

  $(sort $(shell find build/target/product/security -type f -name \*.x509.pem -o -name \*.pk8 -o \

      -name verity_key)) \

  $(sort $(shell find device $(wildcard vendor) -type f -name \*.pk8 -o -name verifiedboot\* -o \

      -name \*.x509.pem -o -name oem\*.prop))



OTATOOLS_RELEASETOOLS := \

  $(shell find build/make/tools/releasetools -name \*.pyc -prune -o -type f | sort)

  $(sort $(shell find build/make/tools/releasetools -name \*.pyc -prune -o -type f))



ifeq (true,$(PRODUCTS.$(INTERNAL_PRODUCT).PRODUCT_SUPPORTS_VBOOT))

OTATOOLS_DEPS += \

  $(shell find external/vboot_reference/tests/devkeys -type f | sort)

  $(sort $(shell find external/vboot_reference/tests/devkeys -type f))

endif



$(BUILT_OTATOOLS_PACKAGE): $(OTATOOLS) $(OTATOOLS_DEPS) $(OTATOOLS_RELEASETOOLS) | $(ACP)

core/aux_config.mk

+1 −1
Original line number Diff line number Diff line
@@ -154,7 +154,7 @@ os_sfx :=_aux_os_config.mk 
config_roots := $(wildcard device vendor)

all_configs :=

ifdef config_roots

all_configs := $(shell find $(config_roots) -maxdepth 4 -name '*$(variant_sfx)' -o -name '*$(os_sfx)' | sort)

all_configs := $(sort $(shell find $(config_roots) -maxdepth 4 -name '*$(variant_sfx)' -o -name '*$(os_sfx)'))

endif

all_os_configs := $(filter %$(os_sfx),$(all_configs))

all_variant_configs := $(filter %$(variant_sfx),$(all_configs))