Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit bb5454b6 authored by Andreas Gampe's avatar Andreas Gampe
Browse files

Build: Add module-level product configuration of sanitization 

To allow special sanitizer settings for modules shared between
products, add product-specific module settings.

This was copied from the product-specific dexopt settings.

Bug: 29498013
Change-Id: I17a96b975bb6ac7f4ffb3d5b08e2f00b21bd97a1
parent e4224c46

core/config_sanitizers.mk

+8 −0
Original line number Diff line number Diff line
@@ -24,6 +24,14 @@ ifneq ($(my_global_sanitize),) 
  my_sanitize := $(my_global_sanitize)

endif



# The sanitizer specified in the product configuration wins over the previous.

ifneq ($(SANITIZER.$(TARGET_PRODUCT).$(LOCAL_MODULE).CONFIG),)

  my_sanitize := $(SANITIZER.$(TARGET_PRODUCT).$(LOCAL_MODULE).CONFIG)

  ifeq ($(my_sanitize),never)

    my_sanitize :=

  endif

endif



# Add a filter point for 32-bit vs 64-bit sanitization (to lighten the burden).

SANITIZE_ARCH ?= 32 64

ifeq ($(filter $(SANITIZE_ARCH),$(my_32_64_bit_suffix)),)

core/product.mk

+12 −0
Original line number Diff line number Diff line
@@ -120,6 +120,7 @@ _product_var_list := \ 
    PRODUCT_DEX_PREOPT_MODULE_CONFIGS \

    PRODUCT_DEX_PREOPT_DEFAULT_FLAGS \

    PRODUCT_DEX_PREOPT_BOOT_FLAGS \

    PRODUCT_SANITIZER_MODULE_CONFIGS \

    PRODUCT_SYSTEM_BASE_FS_PATH \

    PRODUCT_VENDOR_BASE_FS_PATH \

    PRODUCT_SHIPPING_API_LEVEL \
@@ -333,3 +334,14 @@ $(eval _c := $(subst $(space),$(_PDPMC_SP_PLACE_HOLDER),$(strip $(2))))\ 
$(eval PRODUCT_DEX_PREOPT_MODULE_CONFIGS += \

  $(foreach m,$(1),$(m)=$(_c)))

endef



# whitespace placeholder when we record module's sanitizer config.

_PSMC_SP_PLACE_HOLDER := |@SP@|

# Set up sanitizer config for a module.

# $(1) list of module names

# $(2) the modules' sanitizer config

define add-product-sanitizer-module-config

$(eval _c := $(subst $(space),$(_PSMC_SP_PLACE_HOLDER),$(strip $(2))))\

$(eval PRODUCT_SANITIZER_MODULE_CONFIGS += \

  $(foreach m,$(1),$(m)=$(_c)))

endef

core/product_config.mk

+15 −1
Original line number Diff line number Diff line
@@ -392,7 +392,7 @@ PRODUCT_DEX_PREOPT_DEFAULT_FLAGS := \ 
    $(strip $(PRODUCTS.$(INTERNAL_PRODUCT).PRODUCT_DEX_PREOPT_DEFAULT_FLAGS))

PRODUCT_DEX_PREOPT_BOOT_FLAGS := \

    $(strip $(PRODUCTS.$(INTERNAL_PRODUCT).PRODUCT_DEX_PREOPT_BOOT_FLAGS))

# Resolve and setup per-module dex-preopot configs.

# Resolve and setup per-module dex-preopt configs.

PRODUCT_DEX_PREOPT_MODULE_CONFIGS := \

    $(strip $(PRODUCTS.$(INTERNAL_PRODUCT).PRODUCT_DEX_PREOPT_MODULE_CONFIGS))

# If a module has multiple setups, the first takes precedence.
@@ -405,3 +405,17 @@ $(foreach c,$(PRODUCT_DEX_PREOPT_MODULE_CONFIGS),\ 
    $(eval cf := $(subst $(_PDPMC_SP_PLACE_HOLDER),$(space),$(cf)))\

    $(eval DEXPREOPT.$(TARGET_PRODUCT).$(m).CONFIG := $(cf))))

_pdpmc_modules :=



# Resolve and setup per-module sanitizer configs.

PRODUCT_SANITIZER_MODULE_CONFIGS := \

    $(strip $(PRODUCTS.$(INTERNAL_PRODUCT).PRODUCT_SANITIZER_MODULE_CONFIGS))

# If a module has multiple setups, the first takes precedence.

_psmc_modules :=

$(foreach c,$(PRODUCT_SANITIZER_MODULE_CONFIGS),\

  $(eval m := $(firstword $(subst =,$(space),$(c))))\

  $(if $(filter $(_psmc_modules),$(m)),,\

    $(eval _psmc_modules += $(m))\

    $(eval cf := $(patsubst $(m)=%,%,$(c)))\

    $(eval cf := $(subst $(_PSMC_SP_PLACE_HOLDER),$(space),$(cf)))\

    $(eval SANITIZER.$(TARGET_PRODUCT).$(m).CONFIG := $(cf))))

_psmc_modules :=