Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ae7f543b authored by Colin Cross's avatar Colin Cross
Browse files

Disable dexpreopt for aosp_riscv64 

dex2oat isn't supported for riscv64 yet, disable dexpreopt.  For
aosp_riscv64-user and -userdebug builds it is also necessary to
relax the requirement that dexpreopt is enabled.

Test: lunch aosp_riscv64-userdebug && m
Change-Id: I3b66304cedf55f734f8aa1d3ad3ed594a7b9a122
parent 26737b6b

core/board_config.mk

+4 −1
Original line number Diff line number Diff line
@@ -204,8 +204,11 @@ _board_strip_readonly_list += $(_build_broken_var_list) \ 


# Conditional to building on linux, as dex2oat currently does not work on darwin.

ifeq ($(HOST_OS),linux)

  # TODO(riscv64) add compiler support and enable dexpreopt on RISC-V.

  ifneq ($(TARGET_ARCH),riscv64)

    WITH_DEXPREOPT := true

  endif

endif



# ###############################################################

# Broken build defaults

core/dex_preopt_config.mk

+6 −3
Original line number Diff line number Diff line
@@ -65,6 +65,8 @@ ifeq ($(HOST_OS),linux) 
  # Non eng linux builds must have preopt enabled so that system server doesn't run as interpreter

  # only. b/74209329

  ifeq (,$(filter eng, $(TARGET_BUILD_VARIANT)))

    # TODO(riscv64) add compiler support and enable dexpreopt on RISC-V.

    ifeq (,$(filter riscv64, $(TARGET_ARCH)))

      ifneq (true,$(WITH_DEXPREOPT))

        ifneq (true,$(WITH_DEXPREOPT_BOOT_IMG_AND_SYSTEM_SERVER_ONLY))

          $(call pretty-error, DEXPREOPT must be enabled for user and userdebug builds)
@@ -72,6 +74,7 @@ ifeq ($(HOST_OS),linux) 
      endif

    endif

  endif

endif



# Get value of a property. It is first searched from PRODUCT_VENDOR_PROPERTIES

# and then falls back to PRODUCT_SYSTEM_PROPERTIES

target/board/generic_riscv64/BoardConfig.mk

+3 −0
Original line number Diff line number Diff line
@@ -26,3 +26,6 @@ include build/make/target/board/BoardConfigGsiCommon.mk 


# Temporary hack while prebuilt modules are missing riscv64.

ALLOW_MISSING_DEPENDENCIES := true



# Temporary until dex2oat works when targeting riscv64

WITH_DEXPREOPT := false