Commit a65f1aee authored Sep 23, 2015 by Colin Cross Committed by Dan Willemsen Feb 23, 2016

Make multiple rules to generate a file an error

Pass -w dupbuild=err to ninja to make defining multiple rules to build a
file an error instead of a warning. Proceeding with the build would
result in undefined behavior, and nobody notices the warning.

Change-Id: Iadac88f8835121a8685bff835acba638100bb654

parent de407844

core/ninja.mk

+4 −0

Original line number	Diff line number	Diff line
		@@ -116,6 +116,10 @@ ifneq (,$(filter showcommands,$(ORIGINAL_MAKECMDGOALS)))
		NINJA_ARGS += "-v"
		endif

		# Make multiple rules to generate the same target an error instead of
		# proceeding with undefined behavior.
		NINJA_ARGS += -w dupbuild=err

		ifdef USE_GOMA
		KATI_MAKEPARALLEL := $(MAKEPARALLEL)
		# Ninja runs remote jobs (i.e., commands which contain gomacc) with