Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9bfcbc8a authored by Dan Willemsen's avatar Dan Willemsen
Browse files

Move APP-% and PRODUCT-% implementation out of Kati 

This way we'll share ninja files with the equivalent normal configs. We
were already parsing them in the make config step in order to fix
TARGET_PRODUCT / TARGET_BUILD_VARIANT / TARGET_BUILD_APPS, now they
replace themselves in MAKECMDGOALS with the appropriate goals.

If we're not going to pass any goals to ninja, pass the default goal.

Test: ALLOW_MISSING_DEPENDENCIES=true m -j APP-Calculator
Test: m -j PRODUCT-aosp_fugu-eng
Test: m -j PRODUCT-aosp_fugu-eng sdk
Test: m -j PRODUCT-aosp_fugu-sdk
Test: lunch aosp_arm64-userdebug; m -j
Test: lunch aosp_arm64-userdebug; m -j dist
Test: lunch aosp_arm64-userdebug; m -j adb
Change-Id: I73787aff9f74aed328e3fa75c571ae15a28851b0
parent 562bacca

core/ninja_config.mk

+5 −4
Original line number Diff line number Diff line
@@ -7,16 +7,14 @@ endif 
KATI_OUTPUT_PATTERNS := $(OUT_DIR)/build%.ninja $(OUT_DIR)/ninja%.sh



# Modifier goals we don't need to pass to Ninja.

NINJA_EXCLUDE_GOALS := all dist

NINJA_EXCLUDE_GOALS := all dist APP-% PRODUCT-%



# A list of goals which affect parsing of makefiles and we need to pass to Kati.

PARSE_TIME_MAKE_GOALS := \

	$(PARSE_TIME_MAKE_GOALS) \

	$(dont_bother_goals) \

	all \

	APP-% \

	ECLIPSE-% \

	PRODUCT-% \

	AUX-% \

	boottarball-nodeps \

	brillo_tests \
@@ -65,5 +63,8 @@ ANDROID_GOALS := $(filter-out $(KATI_OUTPUT_PATTERNS) $(CKATI) $(MAKEPARALLEL),\ 
    $(sort $(ORIGINAL_MAKECMDGOALS) $(MAKECMDGOALS)))

# Goals we need to pass to Ninja.

NINJA_GOALS := $(filter-out $(NINJA_EXCLUDE_GOALS), $(ANDROID_GOALS))

ifndef NINJA_GOALS

  NINJA_GOALS := droid

endif

# Goals we need to pass to Kati.

KATI_GOALS := $(filter $(PARSE_TIME_MAKE_GOALS), $(ANDROID_GOALS))

core/product_config.mk

+12 −23
Original line number Diff line number Diff line
@@ -88,6 +88,7 @@ INTERNAL_VALID_VARIANTS := user userdebug eng 
# Provide "PRODUCT-<prodname>-<goal>" targets, which lets you build

# a particular configuration without needing to set up the environment.

#

ifndef KATI

product_goals := $(strip $(filter PRODUCT-%,$(MAKECMDGOALS)))

ifdef product_goals

  # Scrape the product and build names out of the goal,
@@ -113,54 +114,42 @@ ifdef product_goals 
    $(error "tests" has been deprecated as a build variant. Use it as a build goal instead.)

  endif



  # The build server wants to do make PRODUCT-dream-installclean

  # which really means TARGET_PRODUCT=dream make installclean.

  # The build server wants to do make PRODUCT-dream-sdk

  # which really means TARGET_PRODUCT=dream make sdk.

  ifneq ($(filter-out $(INTERNAL_VALID_VARIANTS),$(TARGET_BUILD_VARIANT)),)

    MAKECMDGOALS := $(MAKECMDGOALS) $(TARGET_BUILD_VARIANT)

    override MAKECMDGOALS := $(MAKECMDGOALS) $(TARGET_BUILD_VARIANT)

    TARGET_BUILD_VARIANT := userdebug

    default_goal_substitution :=

  else

    default_goal_substitution := $(DEFAULT_GOAL)

    default_goal_substitution := droid

  endif



  # Replace the PRODUCT-* goal with the build goal that it refers to.

  # Note that this will ensure that it appears in the same relative

  # position, in case it matters.

  #

  # Note that modifying this will not affect the goals that make will

  # attempt to build, but it's important because we inspect this value

  # in certain situations (like for "make sdk").

  #

  MAKECMDGOALS := $(patsubst $(goal_name),$(default_goal_substitution),$(MAKECMDGOALS))



  # Define a rule for the PRODUCT-* goal, and make it depend on the

  # patched-up command-line goals as well as any other goals that we

  # want to force.

  #

.PHONY: $(goal_name)

$(goal_name): $(MAKECMDGOALS)

  override MAKECMDGOALS := $(patsubst $(goal_name),$(default_goal_substitution),$(MAKECMDGOALS))

endif

endif # !KATI

# else: Use the value set in the environment or buildspec.mk.



# ---------------------------------------------------------------

# Provide "APP-<appname>" targets, which lets you build

# an unbundled app.

#

ifndef KATI

unbundled_goals := $(strip $(filter APP-%,$(MAKECMDGOALS)))

ifdef unbundled_goals

  ifneq ($(words $(unbundled_goals)),1)

    $(error Only one APP-* goal may be specified; saw "$(unbundled_goals)")

  endif

  TARGET_BUILD_APPS := $(strip $(subst -, ,$(patsubst APP-%,%,$(unbundled_goals))))

  ifneq ($(filter $(DEFAULT_GOAL),$(MAKECMDGOALS)),)

    MAKECMDGOALS := $(patsubst $(unbundled_goals),,$(MAKECMDGOALS))

  ifneq ($(filter droid,$(MAKECMDGOALS)),)

    override MAKECMDGOALS := $(patsubst $(unbundled_goals),,$(MAKECMDGOALS))

  else

    MAKECMDGOALS := $(patsubst $(unbundled_goals),$(DEFAULT_GOAL),$(MAKECMDGOALS))

    override MAKECMDGOALS := $(patsubst $(unbundled_goals),droid,$(MAKECMDGOALS))

  endif



.PHONY: $(unbundled_goals)

$(unbundled_goals): $(MAKECMDGOALS)

endif # unbundled_goals

endif



# Default to building dalvikvm on hosts that support it...

ifeq ($(HOST_OS),linux)