Commit 96c2103c authored Oct 04, 2016 by SteadyQuad Committed by Gerrit Code Review Oct 05, 2016

Show complete command with args when ComputePatch fails

When Difference.ComputePatch() failed for some reason, only
the first part of the failed command was show with the error,
not all arguments.

old (simplified):
WARNING: failure running ['imgdiff', '-b', '/tmp/recovery-resource.dat']:

new:
WARNING: failure running ['imgdiff', '-b', '/tmp/recovery-resource.dat',
  '/tmp/tmpSsy_kf', '/tmp/tmpOMCXSn', '/tmp/tmpA3FtZw']:

Change-Id: Id8b498df3ed7934815430e4b4c2651ef4aa781c6

parent 5f806cb4

tools/releasetools/common.py

+1 −1

Original line number	Diff line number	Diff line
		@@ -1390,7 +1390,7 @@ class Difference(object):

		if err or p.returncode != 0:
		print("WARNING: failure running %s:\n%s\n" % (
		diff_program, "".join(err)))
		cmd, "".join(err)))
		self.patch = None
		return None, None, None
		diff = ptemp.read()