Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 8623157e authored by dianlujitao's avatar dianlujitao
Browse files

Fix false positive when checking ELF prebuilts in PRODUCT_COPY_FILES 

llvm-readobj is valid for other object file types such as PE/COFF, so
some firmware files are wrongly detected as ELF prebuilts. Additionally
check the output of llvm-readobj to avoid such false positives.

Change-Id: I4c4ede747967b4a1213aadaed2f925672d18579c
parent 3617bc1f

core/definitions.mk

+1 −1
Original line number Diff line number Diff line
@@ -3286,7 +3286,7 @@ $(check_non_elf_file_timestamp): $(1) $(LLVM_READOBJ) 
	$(hide) mkdir -p "$$(dir $$@)"

	$(hide) rm -f "$$@"

	$(hide) \

	    if $(LLVM_READOBJ) -h "$$<" >/dev/null 2>&1; then \

	    if $(LLVM_READOBJ) -h "$$<" 2>/dev/null | grep -q "^Format: elf"; then \

	        $(call echo-error,$(2),$(3)); \

	        $(call echo-error,$(2),found ELF file: $$<); \

	        false; \