Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 83980501 authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh
Browse files

Fix severity of analyzer warnings; add new warnings. 

* The following were high severity warnings but mistakenly
  grouped into analyzer warnings in a recent change.
        clang-analyzer-unix.Malloc
        clang-analyzer-cplusplus.NewDeleteLeaks
        clang-analyzer-cplusplus.NewDelete
* Add new Protoc and Kotlin warnings about unused imports and variables.

Bug: 141493530
Test: warn.py --url=http://cs/android --separator='?l=' build.log > warnings.html
Change-Id: Ied1f9ace97f29fba58a40dff2346a0391ab22f06
parent c600707e

tools/warn.py

+8 −3
Original line number Diff line number Diff line
@@ -1749,7 +1749,9 @@ warn_patterns = [ 
    analyzer_warn_check('clang-analyzer-security.insecureAPI.strcpy'),

    analyzer_group_high('clang-analyzer-security.insecureAPI'),

    analyzer_group_high('clang-analyzer-security'),

    analyzer_group_check('clang-analyzer-unix.Malloc'),

    analyzer_high_check('clang-analyzer-unix.Malloc'),

    analyzer_high_check('clang-analyzer-cplusplus.NewDeleteLeaks'),

    analyzer_high_check('clang-analyzer-cplusplus.NewDelete'),

    analyzer_group_check('clang-analyzer-unix'),

    analyzer_group_check('clang-analyzer'),  # catch al
@@ -1767,11 +1769,14 @@ warn_patterns = [ 
    {'category': 'Protoc', 'severity': Severity.MEDIUM,

     'description': 'Proto: Enum name colision after strip',

     'patterns': [r".*: warning: Enum .* has the same name .* ignore case and strip"]},

    {'category': 'Protoc', 'severity': Severity.MEDIUM,

     'description': 'Proto: Import not used',

     'patterns': [r".*: warning: Import .*/.*\.proto but not used.$"]},



    # Kotlin warnings

    {'category': 'Kotlin', 'severity': Severity.MEDIUM,

     'description': 'Kotlin: never used parameter',

     'patterns': [r".*: warning: parameter '.*' is never used"]},

     'description': 'Kotlin: never used parameter or variable',

     'patterns': [r".*: warning: (parameter|variable) '.*' is never used$"]},

    {'category': 'Kotlin', 'severity': Severity.MEDIUM,

     'description': 'Kotlin: Deprecated in Java',

     'patterns': [r".*: warning: '.*' is deprecated. Deprecated in Java"]},