Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7a1da0e4 authored by Dan Willemsen's avatar Dan Willemsen
Browse files

Mark more targets as PHONY 

So that we can start restricting non-phony targets to $OUT_DIR and
$DIST_DIR.

Test: add --writable=out/, see fewer warnings
Change-Id: I411fe4af732b1bce35d4a4c1e2a47b5f8a15e6b8
parent c4ae41b2

core/base_rules.mk

+1 −0
Original line number Diff line number Diff line
@@ -356,6 +356,7 @@ endif 
## make clean- targets

###########################################################

cleantarget := clean-$(my_register_name)

.PHONY: $(cleantarget)

$(cleantarget) : PRIVATE_MODULE := $(my_register_name)

$(cleantarget) : PRIVATE_CLEAN_FILES := \

    $(LOCAL_BUILT_MODULE) \

core/droiddoc.mk

+1 −0
Original line number Diff line number Diff line
@@ -287,6 +287,7 @@ $(out_zip): $(full_target) 
	$(hide) ( F=$$(pwd)/$@ ; cd $(PRIVATE_DOCS_DIR) && zip -rqX $$F * )



$(LOCAL_MODULE)-docs.zip : $(out_zip)

.PHONY: $(LOCAL_MODULE)-docs.zip



$(call dist-for-goals,docs,$(out_zip))

core/host_java_library.mk

+1 −0
Original line number Diff line number Diff line
@@ -93,6 +93,7 @@ $(full_classes_compiled_jar): \ 


javac-check : $(full_classes_compiled_jar)

javac-check-$(LOCAL_MODULE) : $(full_classes_compiled_jar)

.PHONY: javac-check-$(LOCAL_MODULE)



$(full_classes_combined_jar): $(full_classes_compiled_jar) \

                              $(jar_manifest_file) \

core/java.mk

+2 −0
Original line number Diff line number Diff line
@@ -308,6 +308,7 @@ $(full_classes_compiled_jar): \ 


javac-check : $(full_classes_compiled_jar)

javac-check-$(LOCAL_MODULE) : $(full_classes_compiled_jar)

.PHONY: javac-check-$(LOCAL_MODULE)



$(full_classes_combined_jar): PRIVATE_DONT_DELETE_JAR_META_INF := $(LOCAL_DONT_DELETE_JAR_META_INF)

$(full_classes_combined_jar): $(full_classes_compiled_jar) \
@@ -576,6 +577,7 @@ ALL_FINDBUGS_FILES += $(findbugs_xml) 
findbugs_html := $(PRODUCT_OUT)/findbugs/$(LOCAL_MODULE).html

$(findbugs_html) : PRIVATE_XML_FILE := $(findbugs_xml)

$(LOCAL_MODULE)-findbugs : $(findbugs_html)

.PHONY: $(LOCAL_MODULE)-findbugs

$(findbugs_html) : $(findbugs_xml)

	@mkdir -p $(dir $@)

	@echo ConvertXmlToText: $@

core/main.mk

+2 −1
Original line number Diff line number Diff line
@@ -1352,7 +1352,8 @@ $(call dist-for-goals,sdk win_sdk, \ 
# umbrella targets to assit engineers in verifying builds

.PHONY: java native target host java-host java-target native-host native-target \

        java-host-tests java-target-tests native-host-tests native-target-tests \

        java-tests native-tests host-tests target-tests tests java-dex

        java-tests native-tests host-tests target-tests tests java-dex \

        native-host-cross

# some synonyms

.PHONY: host-java target-java host-native target-native \

        target-java-tests target-native-tests