Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 74f121d1 authored by Colin Cross's avatar Colin Cross
Browse files

Rename Native_coverage to GcovCoverage in Soong 

Pass the NATIVE_COVERAGE Make variable to Soong as the more accurate
GcovCoverage.  Also remove NATIVE_LINE_COVERAGE, it doesn't do anything
different from NATIVE_COVERAGE, and NATIVE_COVERAGE is always set when
NATIVE_LINE_COVERAGE is set.

Bug: 159059537
Test: m checkbuild
Change-Id: Ib26a0e29f09b87400fd8bc41d2c06a4a8a397a19
parent 397972fa

core/line_coverage.mk

+2 −3
Original line number Diff line number Diff line
@@ -8,8 +8,7 @@ 
# packs them into another zip file called `line_coverage_profiles.zip`.

#

# To run the make target set the coverage related envvars first:

# 	NATIVE_LINE_COVERAGE=true NATIVE_COVERAGE=true \

#	NATIVE_COVERAGE_PATHS=* make haiku-line-coverage

# 	NATIVE_COVERAGE=true NATIVE_COVERAGE_PATHS=* make haiku-line-coverage

# -----------------------------------------------------------------



# TODO(b/148306195): Due this issue some fuzz targets cannot be built with
@@ -68,7 +67,7 @@ critical_components_shared_inputs := $(foreach lib,$(critical_components_shared) 
fuzz_target_inputs := $(foreach fuzz,$(fuzz_targets), \

	$(call intermediates-dir-for,EXECUTABLES,$(fuzz))/$(fuzz))



# When line coverage is enabled (NATIVE_LINE_COVERAGE is set), make creates

# When coverage is enabled (NATIVE_COVERAGE is set), make creates

# a "coverage" directory and stores all profile (*.gcno) files in inside.

# We need everything that is stored inside this directory.

$(line_coverage_profiles): $(fuzz_target_inputs)

core/soong_config.mk

+1 −2
Original line number Diff line number Diff line
@@ -113,8 +113,7 @@ $(call add_json_str, TidyChecks, $(WITH_TIDY_CHECKS)) 
$(call add_json_list, JavaCoveragePaths,                 $(JAVA_COVERAGE_PATHS))

$(call add_json_list, JavaCoverageExcludePaths,          $(JAVA_COVERAGE_EXCLUDE_PATHS))



$(call add_json_bool, NativeLineCoverage,                $(filter true,$(NATIVE_LINE_COVERAGE)))

$(call add_json_bool, Native_coverage,                   $(filter true,$(NATIVE_COVERAGE)))

$(call add_json_bool, GcovCoverage,                      $(filter true,$(NATIVE_COVERAGE)))

$(call add_json_bool, ClangCoverage,                     $(filter true,$(CLANG_COVERAGE)))

# TODO(b/158212027): Remove `$(COVERAGE_PATHS)` from this list when all users have been moved to

# `NATIVE_COVERAGE_PATHS`.