Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6fa51745 authored by Scott Mertz's avatar Scott Mertz Committed by Sam Mortimer
Browse files

build: add kernel header dependency if module uses kernel headers 

Many of the QCOM components use kernel headers, but don't declare
the dependency on them.  This is fine in CAF because of the way they
build the boot.img before anything else.  In CM, we don't build the
boot.img the same, so we run into a race between the kernel build &
these modules... and the modules lose.

Warn about modules that have this missing dependency, and add it for
them so we don't have to modify each Android.mk.

Change-Id: I95f1e47b5ef440f6f5d8f64a0c3f38d9572e839e
parent 5ff39f59

core/binary.mk

+9 −0
Original line number Diff line number Diff line
@@ -32,6 +32,15 @@ endif 


my_soong_problems :=



# Many qcom modules don't correctly set a dependency on the kernel headers. Fix it for them,

# but warn the user.

ifneq (,$(findstring $(TARGET_OUT_INTERMEDIATES)/KERNEL_OBJ/usr/include,$(LOCAL_C_INCLUDES)))

  ifeq (,$(findstring $(TARGET_OUT_INTERMEDIATES)/KERNEL_OBJ/usr,$(LOCAL_ADDITIONAL_DEPENDENCIES)))

    $(warning $(LOCAL_MODULE) uses kernel headers, but does not depend on them!)

    LOCAL_ADDITIONAL_DEPENDENCIES += $(TARGET_OUT_INTERMEDIATES)/KERNEL_OBJ/usr

  endif

endif



# The following LOCAL_ variables will be modified in this file.

# Because the same LOCAL_ variables may be used to define modules for both 1st arch and 2nd arch,

# we can't modify them in place.