Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6190f691 authored by Yo Chiang's avatar Yo Chiang Committed by Gerrit Code Review
Browse files

Merge "Ban ELF prebuilts in PRODUCT_COPY_FILES"

parents 763c8a76 73d3148c

Changes.md

+13 −0
Original line number Diff line number Diff line 
# Build System Changes for Android.mk Writers



## ELF prebuilts in PRODUCT_COPY_FILES



ELF prebuilts in PRODUCT_COPY_FILES that are installed into these paths are an

error:



* `<partition>/bin/*`

* `<partition>/lib/*`

* `<partition>/lib64/*`



Define prebuilt modules and add them to PRODUCT_PACKAGES instead.

To temporarily relax this check and restore the behavior prior to this change,

set `BUILD_BROKEN_ELF_PREBUILT_PRODUCT_COPY_FILES := true` in `BoardConfig.mk`.



## COPY_HEADERS usage now produces warnings {#copy_headers}



We've considered `BUILD_COPY_HEADERS`/`LOCAL_COPY_HEADERS` to be deprecated for

core/Makefile

+2 −4
Original line number Diff line number Diff line
@@ -40,11 +40,9 @@ $(if $(filter true,$(BUILD_BROKEN_VINTF_PRODUCT_COPY_FILES)),, \ 
)

endef



# TODO(b/140560012): Flip BUILD_BROKEN_ELF_PREBUILT_PRODUCT_COPY_FILES to default

# false after all problematic devices are tagged.

check_elf_prebuilt_product_copy_files :=

ifneq (,$(filter false,$(BUILD_BROKEN_ELF_PREBUILT_PRODUCT_COPY_FILES)))

check_elf_prebuilt_product_copy_files := true

ifneq (,$(filter true,$(BUILD_BROKEN_ELF_PREBUILT_PRODUCT_COPY_FILES)))

check_elf_prebuilt_product_copy_files :=

endif

check_elf_prebuilt_product_copy_files_hint := \

    found ELF prebuilt in PRODUCT_COPY_FILES, use cc_prebuilt_binary / cc_prebuilt_library_shared instead.