Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ae31dde authored by Dan Albert's avatar Dan Albert
Browse files

Add a global define for non-external code. 

There are some code policies we want to enforce more strictly, but
it's hard to do so for third party code because we have to either
carry the diff burden or upstream the patch, and in the latter case
the turnaround time for fixes can be problematic, and sometimes
upstream won't accept changes (sometimes people just need to win the
obfuscated C contest).

We define ANDROID_STRICT for any code that we expect to be able to
make these policy fixes as we change policies.

Change-Id: I15faf62cec1932dd859a082f66942b2606d0ff45
parent 3e0fdfba

core/binary.mk

+15 −0
Original line number Diff line number Diff line
@@ -1346,6 +1346,21 @@ my_cflags := $(filter-out $(my_illegal_flags),$(my_cflags)) 
my_cppflags := $(filter-out $(my_illegal_flags),$(my_cppflags))

my_conlyflags := $(filter-out $(my_illegal_flags),$(my_conlyflags))



# We can enforce some rules more strictly in the code we own. my_strict

# indicates if this is code that we can be stricter with. If we have rules that

# we want to apply to *our* code (but maybe can't for vendor/device specific

# things), we could extend this to be a ternary value.

my_strict := true

ifneq ($(filter external/%,$(LOCAL_PATH)),)

    my_strict := false

endif



# Can be used to make some annotations stricter for code we can fix (such as

# when we mark functions as deprecated).

ifeq ($(my_strict),true)

    my_cflags += -DANDROID_STRICT

endif



$(LOCAL_INTERMEDIATE_TARGETS): PRIVATE_YACCFLAGS := $(LOCAL_YACCFLAGS)

$(LOCAL_INTERMEDIATE_TARGETS): PRIVATE_ASFLAGS := $(my_asflags)

$(LOCAL_INTERMEDIATE_TARGETS): PRIVATE_CONLYFLAGS := $(my_conlyflags)