Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 58634e14 authored by Dan Willemsen's avatar Dan Willemsen
Browse files

Remove AUX support 

This was deprecated in R, which has now branched, and there aren't any
users on master.

Test: build-aosp_crosshatch.ninja is the same (except for the removal of the empty auxiliary target)
Test: treehugger
Change-Id: I306156ab7f91cd4a2258554b4215766c99cd12d1
parent c94417e9

Deprecation.md

+4 −4
Original line number Diff line number Diff line
@@ -14,19 +14,19 @@ have any problems converting, please contact us via: 


| Module type                      | State     |

| -------------------------------- | --------- |

| `BUILD_AUX_EXECUTABLE`           | Error     |

| `BUILD_AUX_STATIC_LIBRARY`       | Error     |

| `BUILD_AUX_EXECUTABLE`           | Obsolete  |

| `BUILD_AUX_STATIC_LIBRARY`       | Obsolete  |

| `BUILD_COPY_HEADERS`             | Error     |

| `BUILD_HOST_EXECUTABLE`          | Error     |

| `BUILD_HOST_FUZZ_TEST`           | Error     |

| `BUILD_HOST_NATIVE_TEST`         | Error     |

| `BUILD_HOST_SHARED_LIBRARY`      | Error     |

| `BUILD_HOST_SHARED_TEST_LIBRARY` | Error     |

| `BUILD_HOST_SHARED_TEST_LIBRARY` | Obsolete  |

| `BUILD_HOST_STATIC_LIBRARY`      | Error     |

| `BUILD_HOST_STATIC_TEST_LIBRARY` | Error     |

| `BUILD_HOST_TEST_CONFIG`         | Error     |

| `BUILD_NATIVE_BENCHMARK`         | Error     |

| `BUILD_SHARED_TEST_LIBRARY`      | Error     |

| `BUILD_SHARED_TEST_LIBRARY`      | Obsolete  |

| `BUILD_STATIC_TEST_LIBRARY`      | Error     |

| `BUILD_TARGET_TEST_CONFIG`       | Error     |

| `BUILD_*`                        | Available |

core/aux_config.mk

deleted100644 → 0
+0 −187
Original line number Diff line number Diff line 
variant_list := $(filter AUX-%,$(MAKECMDGOALS))



ifdef variant_list

AUX_OS_VARIANT_LIST := $(patsubst AUX-%,%,$(variant_list))

else

AUX_OS_VARIANT_LIST := $(TARGET_AUX_OS_VARIANT_LIST)

endif



# exclude AUX targets from build

ifeq ($(AUX_OS_VARIANT_LIST),none)

AUX_OS_VARIANT_LIST :=

endif



# temporary workaround to support external toolchain

ifeq ($(NANOHUB_TOOLCHAIN),)

AUX_OS_VARIANT_LIST :=

endif



# setup toolchain paths for various CPU architectures

# this one will come from android prebuilts eventually

AUX_TOOLCHAIN_cortexm4 := $(NANOHUB_TOOLCHAIN)

ifeq ($(wildcard $(AUX_TOOLCHAIN_cortexm4)gcc),)

AUX_TOOLCHAIN_cortexm4:=

endif



# there is no MAKE var that defines path to HOST toolchain

# all the interesting paths are hardcoded in soong, and are not available from here

# There is no other way but to hardcode them again, as we may need host x86 toolcain for AUX

ifeq ($(HOST_OS),linux)

AUX_TOOLCHAIN_x86 := prebuilts/gcc/linux-x86/host/x86_64-linux-glibc2.15-4.8/bin/x86_64-linux-

endif



# setup AUX globals

AUX_SHLIB_SUFFIX := .so

AUX_GLOBAL_ARFLAGS := crsPD

AUX_STATIC_LIB_SUFFIX := .a



# Load ever-lasting "indexed" version of AUX variant environment; it is treated as READ-ONLY from this

# moment on.

#

# $(1) - variant

# no return value

define aux-variant-setup-paths

$(eval AUX_OUT_ROOT_$(1) := $(PRODUCT_OUT)/aux/$(1)) \

$(eval AUX_COMMON_OUT_ROOT_$(1) := $(AUX_OUT_ROOT_$(1))/common) \

$(eval AUX_OUT_$(1) := $(AUX_OUT_ROOT_$(1))/$(AUX_OS_$(1))-$(AUX_ARCH_$(1))-$(AUX_CPU_$(1))) \

$(eval AUX_OUT_INTERMEDIATES_$(1) := $(AUX_OUT_$(1))/obj) \

$(eval AUX_OUT_COMMON_INTERMEDIATES_$(1) := $(AUX_COMMON_OUT_ROOT_$(1))/obj) \

$(eval AUX_OUT_HEADERS_$(1) := $(AUX_OUT_INTERMEDIATES_$(1))/include) \

$(eval AUX_OUT_NOTICE_FILES_$(1) := $(AUX_OUT_INTERMEDIATES_$(1))/NOTICE_FILES) \

$(eval AUX_OUT_FAKE_$(1) := $(AUX_OUT_$(1))/fake_packages) \

$(eval AUX_OUT_GEN_$(1) := $(AUX_OUT_$(1))/gen) \

$(eval AUX_OUT_COMMON_GEN_$(1) := $(AUX_COMMON_OUT_ROOT_$(1))/gen) \

$(eval AUX_OUT_EXECUTABLES_$(1) := $(AUX_OUT_$(1))/bin) \

$(eval AUX_OUT_UNSTRIPPED_$(1) := $(AUX_OUT_$(1))/symbols)

endef



# Copy "indexed" AUX environment for given VARIANT into

# volatile not-indexed set of variables for simplicity of access.

# Injection of index support throughout the build system is suboptimal

# hence volatile environment is constructed

# Unlike HOST*, TARGET* variables, AUX* variables are NOT read-only, but their

# indexed versions are.

#

# $(1) - variant

# no return value

define aux-variant-load-env

$(eval AUX_OS_VARIANT:=$(1)) \

$(eval AUX_OS:=$(AUX_OS_$(1))) \

$(eval AUX_ARCH:=$(AUX_ARCH_$(1))) \

$(eval AUX_SUBARCH:=$(AUX_SUBARCH_$(1))) \

$(eval AUX_CPU:=$(AUX_CPU_$(1))) \

$(eval AUX_OS_PATH:=$(AUX_OS_PATH_$(1))) \

$(eval AUX_OUT_ROOT := $(AUX_OUT_ROOT_$(1))) \

$(eval AUX_COMMON_OUT_ROOT := $(AUX_COMMON_OUT_ROOT_$(1))) \

$(eval AUX_OUT := $(AUX_OUT_$(1))) \

$(eval AUX_OUT_INTERMEDIATES := $(AUX_OUT_INTERMEDIATES_$(1))) \

$(eval AUX_OUT_COMMON_INTERMEDIATES := $(AUX_OUT_COMMON_INTERMEDIATES_$(1))) \

$(eval AUX_OUT_HEADERS := $(AUX_OUT_HEADERS_$(1))) \

$(eval AUX_OUT_NOTICE_FILES := $(AUX_OUT_NOTICE_FILES_$(1))) \

$(eval AUX_OUT_FAKE := $(AUX_OUT_FAKE_$(1))) \

$(eval AUX_OUT_GEN := $(AUX_OUT_GEN_$(1))) \

$(eval AUX_OUT_COMMON_GEN := $(AUX_OUT_COMMON_GEN_$(1))) \

$(eval AUX_OUT_EXECUTABLES := $(AUX_OUT_EXECUTABLES_$(1))) \

$(eval AUX_OUT_UNSTRIPPED := $(AUX_OUT_UNSTRIPPED_$(1)))

endef



# given a variant:path pair, load the variant conviguration with aux-variant-setup-paths from file

# this is a build system extension mechainsm, since configuration typically resides in non-build

# project space

#

# $(1) - variant:path pair

# $(2) - file suffix

# no return value

define aux-variant-import-from-pair

$(eval _pair := $(subst :, ,$(1))) \

$(eval _name:=$(word 1,$(_pair))) \

$(eval _path:=$(word 2,$(_pair))) \

$(eval include $(_path)/$(_name)$(2)) \

$(eval AUX_OS_VARIANT_LIST_$(AUX_OS_$(1)):=) \

$(call aux-variant-setup-paths,$(_name)) \

$(eval AUX_ALL_VARIANTS += $(_name)) \

$(eval AUX_ALL_OSES := $(filter-out $(AUX_OS_$(_name)),$(AUX_ALL_OSES)) $(AUX_OS_$(_name))) \

$(eval AUX_ALL_CPUS := $(filter-out $(AUX_CPU_$(_name)),$(AUX_ALL_CPUS)) $(AUX_CPU_$(_name))) \

$(eval AUX_ALL_ARCHS := $(filter-out $(AUX_ARCH_$(_name)),$(AUX_ALL_ARCHS)) $(AUX_ARCH_$(_name))) \

$(eval AUX_ALL_SUBARCHS := $(filter-out $(AUX_SUBARCH_$(_name)),$(AUX_ALL_SUBARCHS)) $(AUX_SUBARCH_$(_name)))

endef



# Load system configuration referenced by AUX variant config;

# this is a build extension mechanism; typically system config

# resides in a non-build projects;

# system config may define new rules and globally visible BUILD*

# includes to support project-specific build steps and toolchains

# MAintains list of valiants that reference this os config in OS "indexed" var

# this facilitates multivariant build of the OS (or whataver it is the name of common component these variants share)

#

# $(1) - variant

# no return value

define aux-import-os-config

$(eval _aioc_os := $(AUX_OS_$(1))) \

$(eval AUX_OS_PATH_$(1) := $(patsubst $(_aioc_os):%,%,$(filter $(_aioc_os):%,$(AUX_ALL_OS_PATHS)))) \

$(eval _aioc_os_cfg := $(AUX_OS_PATH_$(1))/$(_aioc_os)$(os_sfx)) \

$(if $(wildcard $(_aioc_os_cfg)),,$(error AUX '$(_aioc_os)' OS config file [$(notdir $(_aioc_os_cfg))] required by AUX variant '$(1)' does not exist)) \

$(if $(filter $(_aioc_os),$(_os_list)),,$(eval include $(_aioc_os_cfg))) \

$(eval AUX_OS_VARIANT_LIST_$(_aioc_os) += $(1)) \

$(eval _os_list += $(_aioc_os))

endef



# make sure that AUX config variables are minimally sane;

# as a bare minimum they must contain the vars described by aux_env

# Generate error if requirement is not met.

#

#$(1) - variant

# no return value

define aux-variant-validate

$(eval _all:=) \

$(eval _req:=$(addsuffix _$(1),$(aux_env))) \

$(foreach var,$(_req),$(eval _all += $(var))) \

$(eval _missing := $(filter-out $(_all),$(_req))) \

$(if $(_missing),$(error AUX variant $(1) must define vars: $(_missing)))

endef



AUX_ALL_VARIANTS :=

AUX_ALL_OSES :=

AUX_ALL_CPUS :=

AUX_ALL_ARCHS :=

AUX_ALL_SUBARCHS :=



variant_sfx :=_aux_variant_config.mk

os_sfx :=_aux_os_config.mk



ifdef AUX_OS_VARIANT_LIST



config_roots := $(wildcard device vendor)

all_configs :=

ifdef config_roots

all_configs := $(sort $(shell find $(config_roots) -maxdepth 4 -name '*$(variant_sfx)' -o -name '*$(os_sfx)'))

endif

all_os_configs := $(filter %$(os_sfx),$(all_configs))

all_variant_configs := $(filter %$(variant_sfx),$(all_configs))



AUX_ALL_OS_PATHS := $(foreach f,$(all_os_configs),$(patsubst %$(os_sfx),%,$(notdir $(f))):$(patsubst %/,%,$(dir $(f))))

AUX_ALL_OS_VARIANT_PATHS := $(foreach f,$(all_variant_configs),$(patsubst %$(variant_sfx),%,$(notdir $(f))):$(patsubst %/,%,$(dir $(f))))



my_variant_pairs := $(foreach v,$(AUX_OS_VARIANT_LIST),$(filter $(v):%,$(AUX_ALL_OS_VARIANT_PATHS)))

my_missing_variants := $(foreach v,$(AUX_OS_VARIANT_LIST),$(if $(filter $(v):%,$(AUX_ALL_OS_VARIANT_PATHS)),,$(v)))



ifneq ($(strip $(my_missing_variants)),)

$(error Don't know how to build variant(s): $(my_missing_variants))

endif



# mandatory variables

aux_env := AUX_OS AUX_ARCH AUX_SUBARCH AUX_CPU



$(foreach v,$(my_variant_pairs),$(if $(filter $(v),$(AUX_ALL_VARIANTS)),,$(call aux-variant-import-from-pair,$(v),$(variant_sfx))))



ifdef AUX_ALL_VARIANTS

_os_list :=

$(foreach v,$(AUX_ALL_VARIANTS),\

  $(call aux-import-os-config,$(v)) \

  $(call aux-variant-validate,$(v)) \

)

endif



endif # AUX_OS_VARIANT_LIST



INSTALLED_AUX_TARGETS :=

core/aux_executable.mk

deleted100644 → 0
+0 −95
Original line number Diff line number Diff line 
# caller might have included aux_toolchain, e.g. if custom build steps are defined

ifeq ($(LOCAL_IS_AUX_MODULE),)

include $(BUILD_SYSTEM)/aux_toolchain.mk

endif



ifeq ($(AUX_BUILD_NOT_COMPATIBLE),)



###########################################################

## Standard rules for building an executable file.

##

## Additional inputs from base_rules.make:

## None.

###########################################################



ifeq ($(strip $(LOCAL_MODULE_CLASS)),)

LOCAL_MODULE_CLASS := EXECUTABLES

endif



$(call $(aux-executable-hook))



###########################################################

## Standard rules for building any target-side binaries

## with dynamic linkage (dynamic libraries or executables

## that link with dynamic libraries)

##

## Files including this file must define a rule to build

## the target $(linked_module).

###########################################################



# The name of the target file, without any path prepended.

# This duplicates logic from base_rules.mk because we need to

# know its results before base_rules.mk is included.

include $(BUILD_SYSTEM)/configure_module_stem.mk



intermediates := $(call local-intermediates-dir)



# Define the target that is the unmodified output of the linker.

# The basename of this target must be the same as the final output

# binary name, because it's used to set the "soname" in the binary.

# The includer of this file will define a rule to build this target.

linked_module := $(intermediates)/LINKED/$(my_built_module_stem)



ALL_ORIGINAL_DYNAMIC_BINARIES += $(linked_module)



# Because AUX_SYMBOL_FILTER_FILE depends on ALL_ORIGINAL_DYNAMIC_BINARIES,

# the linked_module rules won't necessarily inherit the PRIVATE_

# variables from LOCAL_BUILT_MODULE.  This tells binary.make to explicitly

# define the PRIVATE_ variables for linked_module as well as for

# LOCAL_BUILT_MODULE.

LOCAL_INTERMEDIATE_TARGETS += $(linked_module)



###################################

include $(BUILD_SYSTEM)/binary.mk

###################################



aux_output := $(linked_module)



ifneq ($(LOCAL_CUSTOM_BUILD_STEP_INPUT),)

ifneq ($(LOCAL_CUSTOM_BUILD_STEP_OUTPUT),)



# injecting custom build steps

$(LOCAL_CUSTOM_BUILD_STEP_INPUT): $(aux_output)

	@echo "$(AUX_DISPLAY) custom copy: $(PRIVATE_MODULE) ($@)"

	@mkdir -p $(dir $@)

	$(hide) $(copy-file-to-target)



aux_output := $(LOCAL_CUSTOM_BUILD_STEP_OUTPUT)



endif

endif



$(LOCAL_BUILT_MODULE): $(aux_output)

	@echo "$(AUX_DISPLAY) final copy: $(PRIVATE_MODULE) ($@)"

	@mkdir -p $(dir $@)

	$(hide) $(copy-file-to-target)



INSTALLED_AUX_TARGETS += $(LOCAL_INSTALLED_MODULE)



$(cleantarget): PRIVATE_CLEAN_FILES += \

    $(linked_module) \



# Define PRIVATE_ variables from global vars

$(linked_module): PRIVATE_POST_LINK_CMD := $(LOCAL_POST_LINK_CMD)



ifeq ($(LOCAL_FORCE_STATIC_EXECUTABLE),true)

$(linked_module): $(all_objects) $(all_libraries) $(LOCAL_ADDITIONAL_DEPENDENCIES)

	$(transform-o-to-aux-static-executable)

	$(PRIVATE_POST_LINK_CMD)

else

$(linked_module): $(all_objects) $(all_libraries) $(LOCAL_ADDITIONAL_DEPENDENCIES)

	$(transform-o-to-aux-executable)

	$(PRIVATE_POST_LINK_CMD)

endif



endif # AUX_BUILD_NOT_COMPATIBLE

core/aux_static_library.mk

deleted100644 → 0
+0 −27
Original line number Diff line number Diff line 
ifeq ($(LOCAL_IS_AUX_MODULE),)

include $(BUILD_SYSTEM)/aux_toolchain.mk

endif



ifeq ($(AUX_BUILD_NOT_COMPATIBLE),)



ifeq ($(strip $(LOCAL_MODULE_CLASS)),)

LOCAL_MODULE_CLASS := STATIC_LIBRARIES

endif

ifeq ($(strip $(LOCAL_MODULE_SUFFIX)),)

LOCAL_MODULE_SUFFIX := .a

endif



LOCAL_UNINSTALLABLE_MODULE := true



ifneq ($(strip $(LOCAL_MODULE_STEM)$(LOCAL_BUILT_MODULE_STEM)),)

$(error $(LOCAL_PATH): Cannot set module stem for a library)

endif



include $(BUILD_SYSTEM)/binary.mk



$(LOCAL_BUILT_MODULE) : PRIVATE_AR := $(AUX_AR)

$(LOCAL_BUILT_MODULE) : $(built_whole_libraries)

$(LOCAL_BUILT_MODULE) : $(all_objects)

	$(transform-o-to-aux-static-lib)



endif # AUX_BUILD_NOT_COMPATIBLE

core/aux_toolchain.mk

deleted100644 → 0
+0 −52
Original line number Diff line number Diff line 
###########################################################

# takes form LOCAL_AUX_TOOLCHAIN_$(LOCAL_AUX_CPU)

###########################################################



###############################

# setup AUX environment

###############################



# shortcuts for targets with a single instance of OS, ARCH, VARIANT, CPU

AUX_TOOLCHAIN := $(if $(LOCAL_AUX_TOOLCHAIN),$(LOCAL_AUX_TOOLCHAIN),$(AUX_TOOLCHAIN_$(AUX_CPU)))

AUX_BUILD_NOT_COMPATIBLE:=

ifeq ($(strip $(AUX_TOOLCHAIN)),)

  ifeq ($(strip $(AUX_CPU)),)

    $(warning $(LOCAL_PATH): $(LOCAL_MODULE): Undefined CPU for AUX toolchain)

    AUX_BUILD_NOT_COMPATIBLE += TOOLCHAIN

  else

    $(warning $(LOCAL_PATH): $(LOCAL_MODULE): Undefined AUX toolchain for CPU=$(AUX_CPU))

    AUX_BUILD_NOT_COMPATIBLE += TOOLCHAIN

  endif

endif



AUX_BUILD_NOT_COMPATIBLE += $(foreach var,OS ARCH SUBARCH CPU OS_VARIANT,$(if $(LOCAL_AUX_$(var)),$(if \

    $(filter $(LOCAL_AUX_$(var)),$(AUX_$(var))),,$(var))))



AUX_BUILD_NOT_COMPATIBLE := $(strip $(AUX_BUILD_NOT_COMPATIBLE))



ifneq ($(AUX_BUILD_NOT_COMPATIBLE),)

$(info $(LOCAL_PATH): $(LOCAL_MODULE): not compatible: "$(AUX_BUILD_NOT_COMPATIBLE)" with)

$(info ====> OS=$(AUX_OS) CPU=$(AUX_CPU) ARCH=$(AUX_ARCH) SUBARCH=$(AUX_SUBARCH) OS_VARIANT=$(AUX_OS_VARIANT))

$(info ====> TOOLCHAIN=$(AUX_TOOLCHAIN))

endif



AUX_AR := $(AUX_TOOLCHAIN)ar

AUX_AS := $(AUX_TOOLCHAIN)gcc

AUX_CC := $(AUX_TOOLCHAIN)gcc

AUX_CXX := $(AUX_TOOLCHAIN)g++

AUX_LINKER := $(AUX_TOOLCHAIN)ld

AUX_OBJCOPY := $(AUX_TOOLCHAIN)objcopy

AUX_OBJDUMP := $(AUX_TOOLCHAIN)objdump



###############################

# setup Android environment

###############################



LOCAL_IS_AUX_MODULE := true

LOCAL_2ND_ARCH_VAR_PREFIX :=

LOCAL_CC := $(AUX_CC)

LOCAL_CXX := $(AUX_CXX)

LOCAL_NO_DEFAULT_COMPILER_FLAGS := true

LOCAL_SYSTEM_SHARED_LIBRARIES :=

LOCAL_CXX_STL := none

LOCAL_NO_PIC := true