Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 445beae4 authored by Steve Fung's avatar Steve Fung
Browse files

Only generate breakpad symbols for ELF binaries 

When BREAKPAD_GENERATE_SYMBOLS is set to true, the build will attempt
to run dump_syms for all dynamic binaries.  However some build targets
are now using cc_prebuilt_binary for installing python host scripts.
This causes dump_syms to return an error, causing the build to fail.
So check instead if the file is an ELF binary before running dump_syms.

Bug: 65065674
Test: Built AT target successfully.
Merged-In: Ibe7d3ebd312376600cf21efa111489451a4e7578
Change-Id: Ibe7d3ebd312376600cf21efa111489451a4e7578
(cherry picked from commit ee848655)
parent 91ffbf2f

core/dynamic_binary.mk

+7 −2
Original line number Diff line number Diff line
@@ -99,10 +99,15 @@ ifeq ($(BREAKPAD_GENERATE_SYMBOLS),true) 
my_breakpad_path := $(TARGET_OUT_BREAKPAD)/$(patsubst $(PRODUCT_OUT)/%,%,$(my_module_path))

breakpad_input := $(relocation_packer_output)

breakpad_output := $(my_breakpad_path)/$(my_installed_module_stem).sym

$(breakpad_output) : $(breakpad_input) | $(BREAKPAD_DUMP_SYMS)

$(breakpad_output) : $(breakpad_input) | $(BREAKPAD_DUMP_SYMS) $(PRIVATE_READELF)

	@echo "target breakpad: $(PRIVATE_MODULE) ($@)"

	@mkdir -p $(dir $@)

	$(hide) $(BREAKPAD_DUMP_SYMS) -c $< > $@

	$(hide) if $(PRIVATE_READELF) -S $< > /dev/null 2>&1 ; then \

	  $(BREAKPAD_DUMP_SYMS) -c $< > $@ ; \

	else \

	  echo "skipped for non-elf file."; \

	  touch $@; \

	fi

$(LOCAL_BUILT_MODULE) : $(breakpad_output)

endif