Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3d05f68f authored by Kelvin Zhang's avatar Kelvin Zhang
Browse files

Reject SPL downgrade OTAs on release-keys devices 

Test: th
Bug: 270459308
Change-Id: I013324b5b97336366d8e8cbe05e6ade91778b747
parent b9828d64

tools/releasetools/ota_from_target_files.py

+8 −0
Original line number Diff line number Diff line
@@ -1341,6 +1341,14 @@ def main(argv): 
    source_spl = source_build_prop.GetProp(SECURITY_PATCH_LEVEL_PROP_NAME)

    target_spl = target_build_prop.GetProp(SECURITY_PATCH_LEVEL_PROP_NAME)

    is_spl_downgrade = target_spl < source_spl

    if is_spl_downgrade and target_build_prop.GetProp("ro.build.tags") == "release-keys":

      raise common.ExternalError(

          "Target security patch level {} is older than source SPL {} "

          "A locked bootloader will reject SPL downgrade no matter "

          "what(even if data wipe is done), so SPL downgrade on any "

          "release-keys build is not allowed.".format(target_spl, source_spl))



    logger.info("SPL downgrade on %s", target_build_prop.GetProp("ro.build.tags"))

    if is_spl_downgrade and not OPTIONS.spl_downgrade and not OPTIONS.downgrade:

      raise common.ExternalError(

          "Target security patch level {} is older than source SPL {} applying "