Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 38c88241 authored by Steven Moreland's avatar Steven Moreland
Browse files

Reflect MALLOC_ZERO_CONTENTS default true. 

See corresponding build/soong change. This change sets the android
platform to zero all heap allocations by default. To give some
intuition for why this is no so underperformant, zeroing memory is one
way of priming caches.

The main goal of this is to prevent accidental reliance on allocations
being zero, which is UB in C++. In some situations, allocations are
almost always guaranteed to be 0, and so resulting flakes can be
extremely rare.

Bug: 131355925
Test: allocated memory successfully getting zerod
Change-Id: I8c27fbc8c06420a15d022eb810595599d1e56aa0
parent 3443517f

core/soong_config.mk

+1 −1
Original line number Diff line number Diff line
@@ -132,7 +132,7 @@ $(call add_json_list, ExtraVndkVersions, $(PRODUCT_EXTRA_VNDK_VE 
$(call add_json_list, DeviceSystemSdkVersions,           $(BOARD_SYSTEMSDK_VERSIONS))

$(call add_json_list, Platform_systemsdk_versions,       $(PLATFORM_SYSTEMSDK_VERSIONS))

$(call add_json_bool, Malloc_not_svelte,                 $(call invert_bool,$(filter true,$(MALLOC_SVELTE))))

$(call add_json_bool, Malloc_zero_contents,              $(MALLOC_ZERO_CONTENTS))

$(call add_json_bool, Malloc_zero_contents,              $(call invert_bool,$(filter false,$(MALLOC_ZERO_CONTENTS))))

$(call add_json_bool, Malloc_pattern_fill_contents,      $(MALLOC_PATTERN_FILL_CONTENTS))

$(call add_json_str,  Override_rs_driver,                $(OVERRIDE_RS_DRIVER))