Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 36444ab0 authored by Martin Stjernholm's avatar Martin Stjernholm
Browse files

Remove PRODUCT_BOOT_JAR_MODULE_OVERRIDES. 

This reverts commit efe6a4d7.

As a result of b/191269918, APEX variants are now consistently
identified by their "runtime names", i.e. their mount names under
/apex. Those names are now also used to identify the APEXes in
PRODUCT_BOOT_JARS and similar variables. That avoids implementing a
global lookup mechanism in Soong, and since they don't vary between
products also makes this override variable unnecessary.

Test: `m nothing` in internal
Bug: 191269918
Bug: 180325915
Change-Id: I6fd3d29d1c032c9f8bda0191781f9d2dc6f199a4
parent 1b181b06

core/product.mk

+0 −5
Original line number Diff line number Diff line
@@ -372,11 +372,6 @@ _product_list_vars += PRODUCT_MANIFEST_PACKAGE_NAME_OVERRIDES 
_product_list_vars += PRODUCT_PACKAGE_NAME_OVERRIDES

_product_list_vars += PRODUCT_CERTIFICATE_OVERRIDES



# A list of <overridden-apex>:<override-apex> pairs that specifies APEX module

# overrides to be applied to the APEX names in the boot jar variables

# (PRODUCT_BOOT_JARS, PRODUCT_APEX_BOOT_JARS etc).

_product_list_vars += PRODUCT_BOOT_JAR_MODULE_OVERRIDES



# Controls for whether different partitions are built for the current product.

_product_single_value_vars += PRODUCT_BUILD_SYSTEM_IMAGE

_product_single_value_vars += PRODUCT_BUILD_SYSTEM_OTHER_IMAGE

core/product_config.mk

+0 −13
Original line number Diff line number Diff line
@@ -285,19 +285,6 @@ PRODUCT_APEX_BOOT_JARS := $(filter-out com.android.i18n:core-icu4j,$(PRODUCT_APE 
# All APEX jars come after /system and /system_ext jars, so adding core-icu4j at the end of the list

PRODUCT_BOOT_JARS += com.android.i18n:core-icu4j



# Replaces references to overridden boot jar modules in a boot jars variable.

# $(1): Name of a boot jars variable with <apex>:<jar> pairs.

define replace-boot-jar-module-overrides

  $(foreach pair,$(PRODUCT_BOOT_JAR_MODULE_OVERRIDES),\

    $(eval _rbjmo_from := $(call word-colon,1,$(pair)))\

    $(eval _rbjmo_to := $(call word-colon,2,$(pair)))\

    $(eval $(1) := $(patsubst $(_rbjmo_from):%,$(_rbjmo_to):%,$($(1)))))

endef



$(call replace-boot-jar-module-overrides,PRODUCT_BOOT_JARS)

$(call replace-boot-jar-module-overrides,PRODUCT_APEX_BOOT_JARS)

$(call replace-boot-jar-module-overrides,ART_APEX_JARS)



# The extra system server jars must be appended at the end after common system server jars.

PRODUCT_SYSTEM_SERVER_JARS += $(PRODUCT_SYSTEM_SERVER_JARS_EXTRA)