Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 19ed3a0d authored by Ulya Trafimovich's avatar Ulya Trafimovich
Browse files

Make PRODUCT_BOOT_JARS and PRODUCT_UPDATABLE_BOOT_JARS disjoint. 

This is to unify boot jars with system server jars:
PRODUCT_SYSTEM_SERVER_JARS and PRODUCT_UPDATABLE_SYSTEM_SERVER_JARS
do not overlap.

Test: walleye-userdebug boots

Bug: 146363577
Change-Id: Ief8994cc34cb6f7951051313dd66a1334a3a73b4
parent 6750886f

core/product_config.mk

+3 −3
Original line number Diff line number Diff line
@@ -265,9 +265,9 @@ ifdef PRODUCT_DEFAULT_DEV_CERTIFICATE 
endif



$(foreach pair,$(PRODUCT_UPDATABLE_BOOT_JARS), \

  $(if $(findstring $(call word-colon,2,$(pair)),$(PRODUCT_BOOT_JARS)),, \

    $(error Every jar in PRODUCT_UPDATABLE_BOOT_JARS must also be in PRODUCT_BOOT_JARS, \

      $(call word-colon,2,$(pair)) is not) \

  $(if $(findstring $(call word-colon,2,$(pair)),$(PRODUCT_BOOT_JARS)), \

    $(error A jar in PRODUCT_UPDATABLE_BOOT_JARS must not be in PRODUCT_BOOT_JARS, \

      but $(call word-colon,2,$(pair)) is) \

  ) \

)

core/soong_config.mk

+1 −0
Original line number Diff line number Diff line
@@ -138,6 +138,7 @@ $(call add_json_bool, UncompressPrivAppDex, $(call invert_bool,$(fi 
$(call add_json_list, ModulesLoadedByPrivilegedModules,  $(PRODUCT_LOADED_BY_PRIVILEGED_MODULES))



$(call add_json_list, BootJars,                          $(PRODUCT_BOOT_JARS))

$(call add_json_list, UpdatableBootJars,                 $(PRODUCT_UPDATABLE_BOOT_JARS))



$(call add_json_bool, VndkUseCoreVariant,                $(TARGET_VNDK_USE_CORE_VARIANT))

$(call add_json_bool, VndkSnapshotBuildArtifacts,        $(VNDK_SNAPSHOT_BUILD_ARTIFACTS))

core/tasks/boot_jars_package_check.mk

+1 −5
Original line number Diff line number Diff line
@@ -32,11 +32,7 @@ updatable_boot_jars := $(foreach pair,$(PRODUCT_UPDATABLE_BOOT_JARS),\ 
#TODO(jiyong) merge art_boot_jars into updatable_boot_jars

art_boot_jars := $(addsuffix .com.android.art.release,$(filter $(ART_APEX_JARS),$(PRODUCT_BOOT_JARS)))



platform_boot_jars := $(filter-out \

  $(ART_APEX_JARS)\

  $(foreach pair,$(PRODUCT_UPDATABLE_BOOT_JARS),$(call word-colon,2,$(pair))),\

  $(PRODUCT_BOOT_JARS)\

)

platform_boot_jars := $(filter-out $(ART_APEX_JARS),$(PRODUCT_BOOT_JARS))



built_boot_jars := $(foreach j, $(updatable_boot_jars) $(art_boot_jars) $(platform_boot_jars), \

  $(call intermediates-dir-for, JAVA_LIBRARIES, $(j),,COMMON)/classes.jar)

target/product/base_system.mk

+1 −10
Original line number Diff line number Diff line
@@ -323,21 +323,12 @@ endif 


# The order matters for runtime class lookup performance.

PRODUCT_BOOT_JARS := \

    $(TARGET_CORE_JARS) \

    $(ART_APEX_JARS) \

    framework-minus-apex \

    ext \

    telephony-common \

    voip-common \

    ims-common \

    framework-sdkextensions \

    framework-statsd \

    ike \

    updatable-media \

    framework-mediaprovider \

    framework-permission \

    framework-appsearch \

    framework-wifi \

    framework-tethering \

    framework-telephony



PRODUCT_UPDATABLE_BOOT_JARS := \