Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 19c3feb2 authored by Bill Peckham's avatar Bill Peckham
Browse files

Build merged apexkeys.txt/apkcerts.txt by partition. 

Propagate partition tag data to apexkeys.txt and
apkcerts.txt so that merge_target_files.py can build
merged versions of these files by filtering the
framework files for framework partitions and filtering
the vendor files for vendor partitions.

Bug: 138942268
Change-Id: Ic3226728e97dae84d38ec230ccc86d1b124bea94
parent 337f42e7

core/Makefile

+12 −5
Original line number Diff line number Diff line
@@ -861,10 +861,17 @@ endif 
# -----------------------------------------------------------------

# Cert-to-package mapping.  Used by the post-build signing tools.

# Use a macro to add newline to each echo command

# $1 package name

# $2 certificate

# $3 private key

# $4 compressed

# $5 partition tag

# $6 output file

define _apkcerts_write_line

$(hide) echo -n 'name="$(1).apk" certificate="$2" private_key="$3"' >> $5

$(if $(4), $(hide) echo -n ' compressed="$4"' >> $5)

$(hide) echo '' >> $5

$(hide) echo -n 'name="$(1).apk" certificate="$2" private_key="$3"' >> $6

$(if $(4), $(hide) echo -n ' compressed="$4"' >> $6)

$(if $(5), $(hide) echo -n ' partition="$5"' >> $6)

$(hide) echo '' >> $6



endef
@@ -884,8 +891,8 @@ $(APKCERTS_FILE): 
	@rm -f $@

	$(foreach p,$(sort $(PACKAGES)),\

	  $(if $(PACKAGES.$(p).EXTERNAL_KEY),\

	    $(call _apkcerts_write_line,$(p),"EXTERNAL","",$(PACKAGES.$(p).COMPRESSED),$@),\

	    $(call _apkcerts_write_line,$(p),$(PACKAGES.$(p).CERTIFICATE),$(PACKAGES.$(p).PRIVATE_KEY),$(PACKAGES.$(p).COMPRESSED),$@)))

	    $(call _apkcerts_write_line,$(p),"EXTERNAL","",$(PACKAGES.$(p).COMPRESSED),$(PACKAGES.$(p).PARTITION),$@),\

	    $(call _apkcerts_write_line,$(p),$(PACKAGES.$(p).CERTIFICATE),$(PACKAGES.$(p).PRIVATE_KEY),$(PACKAGES.$(p).COMPRESSED),$(PACKAGES.$(p).PARTITION),$@)))

	# In case value of PACKAGES is empty.

	$(hide) touch $@

core/app_prebuilt_internal.mk

+3 −0
Original line number Diff line number Diff line
@@ -167,6 +167,9 @@ endif 


include $(BUILD_SYSTEM)/app_certificate_validate.mk



# Set a actual_partition_tag (calculated in base_rules.mk) for the package.

PACKAGES.$(LOCAL_MODULE).PARTITION := $(actual_partition_tag)



# Disable dex-preopt of prebuilts to save space, if requested.

ifndef LOCAL_DEX_PREOPT

ifeq ($(DONT_DEXPREOPT_PREBUILTS),true)

core/base_rules.mk

+16 −0
Original line number Diff line number Diff line
@@ -208,23 +208,39 @@ my_module_path := $(patsubst %/,%,$(my_module_path)) 
my_module_relative_path := $(strip $(LOCAL_MODULE_RELATIVE_PATH))

ifdef LOCAL_IS_HOST_MODULE

  partition_tag :=

  actual_partition_tag :=

else

ifeq (true,$(strip $(LOCAL_VENDOR_MODULE)))

  partition_tag := _VENDOR

  # A vendor module could be on the vendor partition at "vendor" or the system

  # partition at "system/vendor".

  actual_partition_tag := $(if $(filter true,$(BOARD_USES_VENDORIMAGE)),vendor,system)

else ifeq (true,$(strip $(LOCAL_OEM_MODULE)))

  partition_tag := _OEM

  actual_partition_tag := oem

else ifeq (true,$(strip $(LOCAL_ODM_MODULE)))

  partition_tag := _ODM

  # An ODM module could be on the odm partition at "odm", the vendor partition

  # at "vendor/odm", or the system partition at "system/vendor/odm".

  actual_partition_tag := $(if $(filter true,$(BOARD_USES_ODMIMAGE)),odm,$(if $(filter true,$(BOARD_USES_VENDORIMAGE)),vendor,system))

else ifeq (true,$(strip $(LOCAL_PRODUCT_MODULE)))

  partition_tag := _PRODUCT

  # A product module could be on the product partition at "product" or the

  # system partition at "system/product".

  actual_partition_tag := $(if $(filter true,$(BOARD_USES_PRODUCTIMAGE)),product,system)

else ifeq (true,$(strip $(LOCAL_SYSTEM_EXT_MODULE)))

  partition_tag := _SYSTEM_EXT

  # A system_ext-specific module could be on the system_ext partition at

  # "system_ext" or the system partition at "system/system_ext".

  actual_partition_tag := $(if $(filter true,$(BOARD_USES_SYSTEM_EXTIMAGE)),system_ext,system)

else ifeq (NATIVE_TESTS,$(LOCAL_MODULE_CLASS))

  partition_tag := _DATA

  actual_partition_tag := data

else

  # The definition of should-install-to-system will be different depending

  # on which goal (e.g., sdk or just droid) is being built.

  partition_tag := $(if $(call should-install-to-system,$(my_module_tags)),,_DATA)

  actual_partition_tag := $(if $(partition_tag),data,system)

endif

endif

# For test modules that lack a suite tag, set null-suite as the default.

core/package_internal.mk

+3 −0
Original line number Diff line number Diff line
@@ -471,6 +471,9 @@ PACKAGES.$(LOCAL_PACKAGE_NAME).CERTIFICATE := $(certificate) 
$(LOCAL_BUILT_MODULE): $(additional_certificates)

$(LOCAL_BUILT_MODULE): PRIVATE_ADDITIONAL_CERTIFICATES := $(additional_certificates)



# Set a actual_partition_tag (calculated in base_rules.mk) for the package.

PACKAGES.$(LOCAL_PACKAGE_NAME).PARTITION := $(actual_partition_tag)



# Verify LOCAL_USES_LIBRARIES/LOCAL_OPTIONAL_USES_LIBRARIES

# If LOCAL_ENFORCE_USES_LIBRARIES is not set, default to true if either of LOCAL_USES_LIBRARIES or

# LOCAL_OPTIONAL_USES_LIBRARIES are specified.

core/soong_app_prebuilt.mk

+3 −0
Original line number Diff line number Diff line
@@ -157,6 +157,9 @@ endif 
include $(BUILD_SYSTEM)/app_certificate_validate.mk

PACKAGES.$(LOCAL_MODULE).OVERRIDES := $(strip $(LOCAL_OVERRIDES_PACKAGES))



# Set a actual_partition_tag (calculated in base_rules.mk) for the package.

PACKAGES.$(LOCAL_MODULE).PARTITION := $(actual_partition_tag)



ifdef LOCAL_SOONG_BUNDLE

  ALL_MODULES.$(LOCAL_MODULE).BUNDLE := $(LOCAL_SOONG_BUNDLE)

endif