Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 18a141cc authored by Daniel Micay's avatar Daniel Micay Committed by Nick Kralevich
Browse files

set ro.adb.secure=1 for user builds 

In user builds, adb without authentication is always disabled. However,
it doesn't work with the defaults because authentication doesn't work
without having ro.adb.secure=1 set. It makes sense to offer builds with
no adb but not builds with adb present in an unusable state (especially
as the default).

Bug: 22220212
Bug: 21862859
Change-Id: Ic22300a70586fd57692ac59d6873ab16dde70919
parent d49e5556

core/build-system.html

+1 −0
Original line number Diff line number Diff line
@@ -270,6 +270,7 @@ for these). 
        <li>Installs non-APK modules that have no tags specified.

        <li>Installs APKs according to the product definition files; tags

            are ignored for APK modules.

        <li><code>ro.adb.secure=1</code>

        <li><code>ro.secure=1</code>

        <li><code>ro.debuggable=0</code>

        <li><code>adb</code> is disabled by default.

core/main.mk

+4 −0
Original line number Diff line number Diff line
@@ -360,6 +360,10 @@ ifneq (,$(user_variant)) 
  # Target is secure in user builds.

  ADDITIONAL_DEFAULT_PROPERTIES += ro.secure=1



  ifeq ($(user_variant),user)

    ADDITIONAL_DEFAULT_PROPERTIES += ro.adb.secure=1

  endif



  ifeq ($(user_variant),userdebug)

    # Pick up some extra useful tools

    tags_to_install += debug