Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 18042e19 authored by Elliott Hughes's avatar Elliott Hughes
Browse files

Turn 64-bit-related warnings into errors on 64-bit builds. 

I don't think we can realistically turn this on for 32-bit builds any
time soon.

Also, fix the arm64 stack-protector hack.

Change-Id: Ie1e7c875bbc06fb21bb372b8ca99879a23ef53d4
parent 5352018b

core/combo/TARGET_linux-arm64.mk

+9 −2
Original line number Diff line number Diff line
@@ -78,6 +78,11 @@ TARGET_GLOBAL_CFLAGS += \ 


android_config_h := $(call select-android-config-h,linux-arm64)



# HACK: globally disable -fstack-protector until the toolchain supports it

TARGET_GLOBAL_UNSUPPORTED_CFLAGS := \

    -fstack-protector \

    -fstack-protector-all \



TARGET_GLOBAL_CFLAGS += \

			-fpic -fPIE \

			-ffunction-sections \
@@ -91,8 +96,10 @@ TARGET_GLOBAL_CFLAGS += \ 
			-include $(android_config_h) \

			-I $(dir $(android_config_h))



# HACK: globally disable -fstack-protector until the toolchain supports it

TARGET_GLOBAL_UNSUPPORTED_CFLAGS := -fstack-protector

# Help catch common 32/64-bit errors.

TARGET_GLOBAL_CFLAGS += \

    -Werror=pointer-to-int-cast \

    -Werror=int-to-pointer-cast \



# TODO - remove __ANDROID__ after the next aarch64 toolchain refresh

TARGET_GLOBAL_CFLAGS += -D__ANDROID__=1

core/combo/TARGET_linux-x86_64.mk

+5 −0
Original line number Diff line number Diff line
@@ -126,6 +126,11 @@ TARGET_GLOBAL_CFLAGS += \ 
			-fstack-protector \

			-m64



# Help catch common 32/64-bit errors.

TARGET_GLOBAL_CFLAGS += \

    -Werror=pointer-to-int-cast \

    -Werror=int-to-pointer-cast \



android_config_h := $(call select-android-config-h,target_linux-x86)

TARGET_ANDROID_CONFIG_CFLAGS := -include $(android_config_h) -I $(dir $(android_config_h))

TARGET_GLOBAL_CFLAGS += $(TARGET_ANDROID_CONFIG_CFLAGS)