Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 10eac08f authored by Kelvin Zhang's avatar Kelvin Zhang
Browse files

Add ro.vendor.build.dont_use_vabc to disable VABC OTA 

This prop is owned by OEM, OEM can set this if they want to disable
VABC.

Test: m dist, make sure generated OTA has VABC disabled
Bug: 185400304

Change-Id: Iceb2fb1f399d38a51722352a86ddf68af05fa24e
parent 9c17b26e

core/main.mk

+7 −0
Original line number Diff line number Diff line
@@ -311,6 +311,13 @@ ADDITIONAL_VENDOR_PROPERTIES += \ 
endif

endif



# Set build prop. This prop is read by ota_from_target_files when generating OTA,

# to decide if VABC should be disabled.

ifeq ($(BOARD_DONT_USE_VABC_OTA),true)

ADDITIONAL_VENDOR_PROPERTIES += \

    ro.vendor.build.dont_use_vabc=true

endif



# Set the flag in vendor. So VTS would know if the new fingerprint format is in use when

# the system images are replaced by GSI.

ifeq ($(BOARD_USE_VBMETA_DIGTEST_IN_FINGERPRINT),true)

tools/releasetools/common.py

+7 −0
Original line number Diff line number Diff line
@@ -453,6 +453,13 @@ class BuildInfo(object): 
        vendor_prop.GetProp("ro.virtual_ab.compression.enabled") == "true"

    return vabc_enabled



  @property

  def vendor_suppressed_vabc(self):

    vendor_prop = self.info_dict.get("vendor.build.prop")

    vabc_suppressed = vendor_prop and \

        vendor_prop.GetProp("ro.vendor.build.dont_use_vabc")

    return vabc_suppressed and vabc_suppressed.lower() == "true"



  @property

  def oem_props(self):

    return self._oem_props

tools/releasetools/ota_from_target_files.py

+4 −0
Original line number Diff line number Diff line
@@ -1076,6 +1076,7 @@ def GenerateAbOtaPackage(target_file, output_file, source_file=None): 
    # serve I/O request when device boots. Therefore, disable VABC if source

    # build doesn't supports it.

    if not source_info.is_vabc or not target_info.is_vabc:

      logger.info("Either source or target does not support VABC, disabling.")

      OPTIONS.disable_vabc = True



  else:
@@ -1084,6 +1085,9 @@ def GenerateAbOtaPackage(target_file, output_file, source_file=None): 
    target_info = common.BuildInfo(OPTIONS.info_dict, OPTIONS.oem_dicts)

    source_info = None



  if target_info.vendor_suppressed_vabc:

    logger.info("Vendor suppressed VABC. Disabling")

    OPTIONS.disable_vabc = True

  additional_args = []



  # Prepare custom images.