Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 23abfd37 authored by Chih-Hung Hsieh's avatar Chih-Hung Hsieh
Browse files

Fix clang-tidy performance warnings. 

* Use const reference parameter type to avoid unnecessary copy.
* Use more efficient overloaded string methods.

Bug: 30407689
Bug: 30411878
Change-Id: Iefab05c077367f272abf545036b853e8a295c8cd
Test: build with WITH_TIDY=1
parent a82ee456

minui/events.cpp

+1 −1
Original line number Diff line number Diff line
@@ -204,7 +204,7 @@ int ev_sync_key_state(ev_set_key_callback set_key_cb, void* data) { 
    return 0;

}



void ev_iterate_available_keys(std::function<void(int)> f) {

void ev_iterate_available_keys(const std::function<void(int)>& f) {

    // Use unsigned long to match ioctl's parameter type.

    unsigned long ev_bits[BITS_TO_LONGS(EV_MAX)]; // NOLINT

    unsigned long key_bits[BITS_TO_LONGS(KEY_MAX)]; // NOLINT

minui/minui.h

+1 −1
Original line number Diff line number Diff line
@@ -67,7 +67,7 @@ typedef int (*ev_set_key_callback)(int code, int value, void* data); 
int ev_init(ev_callback input_cb, void* data);

void ev_exit();

int ev_add_fd(int fd, ev_callback cb, void* data);

void ev_iterate_available_keys(std::function<void(int)> f);

void ev_iterate_available_keys(const std::function<void(int)>& f);

int ev_sync_key_state(ev_set_key_callback set_key_cb, void* data);



// 'timeout' has the same semantics as poll(2).

otafault/ota_io.cpp

+1 −1
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ static std::string write_fault_file_name = ""; 
static std::string fsync_fault_file_name = "";

bool have_eio_error = false;



static bool get_hit_file(const char* cached_path, std::string ffn) {

static bool get_hit_file(const char* cached_path, const std::string& ffn) {

    return should_hit_cache()

        ? !strncmp(cached_path, OTAIO_CACHE_FNAME, strlen(cached_path))

        : !strncmp(cached_path, ffn.c_str(), strlen(cached_path));

recovery-refresh.cpp

+1 −1
Original line number Diff line number Diff line
@@ -76,7 +76,7 @@ static ssize_t logrotate( 
    }



    std::string name(filename);

    size_t dot = name.find_last_of(".");

    size_t dot = name.find_last_of('.');

    std::string sub = name.substr(0, dot);



    if (!strstr(LAST_KMSG_FILE, sub.c_str()) &&

recovery.cpp

+1 −1
Original line number Diff line number Diff line
@@ -1274,7 +1274,7 @@ static ssize_t logrotate( 
    }



    std::string name(filename);

    size_t dot = name.find_last_of(".");

    size_t dot = name.find_last_of('.');

    std::string sub = name.substr(0, dot);



    if (!strstr(LAST_KMSG_FILE, sub.c_str()) &&