Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0f275ae5 authored by Treehugger Robot's avatar Treehugger Robot Committed by Gerrit Code Review
Browse files

Merge "Avoid to call UI functions in child process"

parents c44c4791 ab1abae5
Loading
Loading
Loading
Loading
+5 −1
Original line number Diff line number Diff line
@@ -382,7 +382,11 @@ static int try_update_binary(const char* path, ZipArchiveHandle zip, bool* wipe_
    umask(022);
    close(pipefd[0]);
    execv(chr_args[0], const_cast<char**>(chr_args));
    PLOG(ERROR) << "Can't run " << chr_args[0];
    // Bug: 34769056
    // We shouldn't use LOG/PLOG in the forked process, since they may cause
    // the child process to hang. This deadlock results from an improperly
    // copied mutex in the ui functions.
    fprintf(stdout, "E:Can't run %s (%s)\n", chr_args[0], strerror(errno));
    _exit(-1);
  }
  close(pipefd[1]);