From de7c16590c6a90e53e21454b0373c87ff0ff8d36 Mon Sep 17 00:00:00 2001 From: jacquarg Date: Fri, 25 Apr 2025 11:58:04 +0200 Subject: [PATCH 1/2] fix: sentry: Crash when geenrating reports with empty trackers database. --- .../advancedprivacy/domain/usecases/WeeklyReportUseCase.kt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/foundation/e/advancedprivacy/domain/usecases/WeeklyReportUseCase.kt b/app/src/main/java/foundation/e/advancedprivacy/domain/usecases/WeeklyReportUseCase.kt index 94d04a56..1d5535b1 100644 --- a/app/src/main/java/foundation/e/advancedprivacy/domain/usecases/WeeklyReportUseCase.kt +++ b/app/src/main/java/foundation/e/advancedprivacy/domain/usecases/WeeklyReportUseCase.kt @@ -110,7 +110,12 @@ class WeeklyReportUseCase( private suspend fun addCallPerAppCandidates(candidates: MutableList, endOfWeek: Instant) { val startOfWeek = getStartOfWeek(endOfWeek) - val (appIdWithMostCalls, callsPerWeek) = statsDatabase.getCallsByAppIds(startOfWeek, endOfWeek).maxBy { it.value } + val callsByAppIds = statsDatabase.getCallsByAppIds(startOfWeek, endOfWeek) + if (callsByAppIds.isEmpty()) { + return + } + + val (appIdWithMostCalls, callsPerWeek) = callsByAppIds.maxBy { it.value } val app = appListRepository.getAppById(appIdWithMostCalls)?.id // TODO: get second one on fail ? -- GitLab From c365a016afae027bf217c73dc372e6a380e58451 Mon Sep 17 00:00:00 2001 From: jacquarg Date: Mon, 5 May 2025 11:09:24 +0200 Subject: [PATCH 2/2] fix:sentry-6550511662: Crash in DebugActivity. --- .../advancedprivacy/features/debug/DebugWeeklyReportFragment.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/foundation/e/advancedprivacy/features/debug/DebugWeeklyReportFragment.kt b/app/src/main/java/foundation/e/advancedprivacy/features/debug/DebugWeeklyReportFragment.kt index 57453f3b..c1105a27 100644 --- a/app/src/main/java/foundation/e/advancedprivacy/features/debug/DebugWeeklyReportFragment.kt +++ b/app/src/main/java/foundation/e/advancedprivacy/features/debug/DebugWeeklyReportFragment.kt @@ -183,7 +183,7 @@ class DebugWeeklyReportFragment : Fragment(R.layout.debug_weekly_report_fragment val timestamp = Instant.now() // Call Per App - val anyApp = appListRepository.displayableApps.value.first() + val anyApp = appListRepository.displayableApps.value.firstOrNull() ?: return emptyList() val callsPerWeek = Random.nextInt(10000) val hoursInWeek = 7 * 24 -- GitLab