From 87cb5b4f8afbb924aa2275563bdb4fd83c2d217a Mon Sep 17 00:00:00 2001
From: Fahim <fahim.cse11@gmail.com>
Date: Wed, 13 Oct 2021 23:46:41 +0600
Subject: [PATCH] 3954-Navigation_bar_divider_color_issue

issue: https://gitlab.e.foundation/e/backlog/-/issues/3954
---
 .../src/main/res/drawable/ic_reply_white_24dp.xml      |  3 ++-
 .../main/res/layout/attachment_contact_list_item.xml   |  4 ++--
 .../src/main/res/layout/attachment_image_list_item.xml |  2 +-
 presentation/src/main/res/layout/backup_controller.xml |  4 ++--
 .../src/main/res/layout/blocked_number_list_item.xml   |  2 +-
 presentation/src/main/res/layout/compose_activity.xml  | 10 +++++-----
 .../src/main/res/layout/container_activity.xml         |  6 ------
 presentation/src/main/res/layout/main_activity.xml     |  2 +-
 .../src/main/res/layout/mms_file_list_item.xml         |  2 +-
 .../src/main/res/layout/mms_vcard_list_item.xml        |  2 +-
 .../main/res/layout/notification_prefs_activity.xml    |  2 +-
 .../src/main/res/layout/qksms_plus_activity.xml        |  2 +-
 .../src/main/res/layout/scheduled_activity.xml         |  2 +-
 presentation/src/main/res/values-night/themes.xml      |  4 +++-
 presentation/src/main/res/values-v27/themes.xml        |  1 +
 presentation/src/main/res/values/themes.xml            |  4 +++-
 16 files changed, 26 insertions(+), 26 deletions(-)

diff --git a/presentation/src/main/res/drawable/ic_reply_white_24dp.xml b/presentation/src/main/res/drawable/ic_reply_white_24dp.xml
index 649cc2b08..494a1bcce 100644
--- a/presentation/src/main/res/drawable/ic_reply_white_24dp.xml
+++ b/presentation/src/main/res/drawable/ic_reply_white_24dp.xml
@@ -20,7 +20,8 @@
     android:width="24dp"
     android:height="24dp"
     android:viewportWidth="24.0"
-    android:viewportHeight="24.0">
+    android:viewportHeight="24.0"
+    android:tint="@color/colorAccent">
     <path
         android:fillColor="#FFFFFFFF"
         android:pathData="M10,9V5l-7,7 7,7v-4.1c5,0 8.5,1.6 11,5.1 -1,-5 -4,-10 -11,-11z" />
diff --git a/presentation/src/main/res/layout/attachment_contact_list_item.xml b/presentation/src/main/res/layout/attachment_contact_list_item.xml
index 1c9f88837..17fbcf95b 100644
--- a/presentation/src/main/res/layout/attachment_contact_list_item.xml
+++ b/presentation/src/main/res/layout/attachment_contact_list_item.xml
@@ -40,7 +40,7 @@
             android:layout_height="24dp"
             android:layout_marginStart="16dp"
             android:src="@drawable/ic_person_black_24dp"
-            android:tint="?android:attr/textColorSecondary"
+            android:tint="@color/colorAccent"
             app:layout_constraintBottom_toBottomOf="parent"
             app:layout_constraintStart_toStartOf="parent"
             app:layout_constraintTop_toTopOf="parent" />
@@ -88,6 +88,6 @@
         android:background="@drawable/circle"
         android:backgroundTint="?attr/bubbleColor"
         android:src="@drawable/ic_cancel_black_24dp"
-        android:tint="?android:attr/textColorSecondary" />
+        android:tint="@color/colorAccent" />
 
 </FrameLayout>
\ No newline at end of file
diff --git a/presentation/src/main/res/layout/attachment_image_list_item.xml b/presentation/src/main/res/layout/attachment_image_list_item.xml
index ff757f035..876e377a2 100644
--- a/presentation/src/main/res/layout/attachment_image_list_item.xml
+++ b/presentation/src/main/res/layout/attachment_image_list_item.xml
@@ -51,6 +51,6 @@
         android:background="@drawable/circle"
         android:backgroundTint="?attr/bubbleColor"
         android:src="@drawable/ic_cancel_black_24dp"
-        android:tint="?android:attr/textColorSecondary" />
+        android:tint="@color/colorAccent" />
 
 </FrameLayout>
\ No newline at end of file
diff --git a/presentation/src/main/res/layout/backup_controller.xml b/presentation/src/main/res/layout/backup_controller.xml
index 23de4cf77..e5ce20c2b 100644
--- a/presentation/src/main/res/layout/backup_controller.xml
+++ b/presentation/src/main/res/layout/backup_controller.xml
@@ -48,7 +48,7 @@
                     android:layout_width="24dp"
                     android:layout_height="24dp"
                     android:layout_marginStart="16dp"
-                    android:tint="?android:attr/textColorSecondary"
+                    android:tint="@color/colorAccent"
                     app:layout_constraintBottom_toBottomOf="@id/progressSummary"
                     app:layout_constraintStart_toStartOf="parent"
                     app:layout_constraintTop_toTopOf="@id/progressTitle"
@@ -87,7 +87,7 @@
                     android:background="?android:attr/selectableItemBackground"
                     android:padding="16dp"
                     android:src="@drawable/ic_close_black_24dp"
-                    android:tint="?android:attr/textColorSecondary"
+                    android:tint="@color/colorAccent"
                     app:layout_constraintBottom_toBottomOf="@id/progressSummary"
                     app:layout_constraintEnd_toEndOf="parent"
                     app:layout_constraintTop_toTopOf="@id/progressTitle" />
diff --git a/presentation/src/main/res/layout/blocked_number_list_item.xml b/presentation/src/main/res/layout/blocked_number_list_item.xml
index 93bcb8934..bf3c8316f 100644
--- a/presentation/src/main/res/layout/blocked_number_list_item.xml
+++ b/presentation/src/main/res/layout/blocked_number_list_item.xml
@@ -42,6 +42,6 @@
         android:background="?android:attr/selectableItemBackground"
         android:padding="12dp"
         android:src="@drawable/ic_close_black_24dp"
-        android:tint="?android:attr/textColorSecondary" />
+        android:tint="@color/colorAccent" />
 
 </LinearLayout>
\ No newline at end of file
diff --git a/presentation/src/main/res/layout/compose_activity.xml b/presentation/src/main/res/layout/compose_activity.xml
index 3a52e4297..6c7dd1535 100644
--- a/presentation/src/main/res/layout/compose_activity.xml
+++ b/presentation/src/main/res/layout/compose_activity.xml
@@ -392,7 +392,7 @@
     <View
         android:layout_width="match_parent"
         android:layout_height="1dp"
-        android:background="?android:attr/divider"
+        android:background="@color/backgroundDark"
         app:layout_constraintBottom_toBottomOf="parent" />
 
     <androidx.constraintlayout.widget.Group
@@ -425,7 +425,7 @@
         android:elevation="4dp"
         android:padding="10dp"
         android:src="@drawable/ic_person_black_24dp"
-        android:tint="?android:attr/textColorSecondary"
+        android:tint="@color/colorAccent"
         android:visibility="visible"
         app:layout_constraintBottom_toTopOf="@id/schedule"
         app:layout_constraintEnd_toEndOf="@id/attach"
@@ -459,7 +459,7 @@
         android:elevation="4dp"
         android:padding="10dp"
         android:src="@drawable/ic_event_black_24dp"
-        android:tint="?android:attr/textColorSecondary"
+        android:tint="@color/colorAccent"
         android:visibility="visible"
         app:layout_constraintBottom_toTopOf="@id/gallery"
         app:layout_constraintEnd_toEndOf="@id/attach"
@@ -493,7 +493,7 @@
         android:elevation="4dp"
         android:padding="10dp"
         android:src="@drawable/ic_insert_photo_black_24dp"
-        android:tint="?android:attr/textColorSecondary"
+        android:tint="@color/colorAccent"
         android:visibility="visible"
         app:layout_constraintBottom_toTopOf="@id/camera"
         app:layout_constraintEnd_toEndOf="@id/attach"
@@ -527,7 +527,7 @@
         android:elevation="4dp"
         android:padding="10dp"
         android:src="@drawable/ic_camera_alt_black_24dp"
-        android:tint="?android:attr/textColorSecondary"
+        android:tint="@color/colorAccent"
         android:visibility="visible"
         app:layout_constraintBottom_toTopOf="@id/attach"
         app:layout_constraintEnd_toEndOf="@id/attach"
diff --git a/presentation/src/main/res/layout/container_activity.xml b/presentation/src/main/res/layout/container_activity.xml
index 16ca0bb15..4afa326b7 100644
--- a/presentation/src/main/res/layout/container_activity.xml
+++ b/presentation/src/main/res/layout/container_activity.xml
@@ -40,10 +40,4 @@
         android:layout_height="0dp"
         android:layout_weight="1"
         android:background="?android:attr/windowBackground" />
-
-    <View
-        android:layout_width="match_parent"
-        android:layout_height="1dp"
-        android:background="?android:attr/divider" />
-
 </LinearLayout>
\ No newline at end of file
diff --git a/presentation/src/main/res/layout/main_activity.xml b/presentation/src/main/res/layout/main_activity.xml
index 973b1b22a..bf776b00f 100644
--- a/presentation/src/main/res/layout/main_activity.xml
+++ b/presentation/src/main/res/layout/main_activity.xml
@@ -112,7 +112,7 @@
             android:id="@+id/bottom"
             android:layout_width="match_parent"
             android:layout_height="1dp"
-            android:background="?android:attr/divider"
+            android:background="@color/backgroundDark"
             app:layout_constraintBottom_toTopOf="@id/snackbar" />
 
         <ViewStub
diff --git a/presentation/src/main/res/layout/mms_file_list_item.xml b/presentation/src/main/res/layout/mms_file_list_item.xml
index 4c1550ee9..1ff74e07e 100644
--- a/presentation/src/main/res/layout/mms_file_list_item.xml
+++ b/presentation/src/main/res/layout/mms_file_list_item.xml
@@ -35,7 +35,7 @@
             android:layout_height="24dp"
             android:layout_marginStart="12dp"
             android:src="@drawable/ic_attachment_black_24dp"
-            android:tint="?android:attr/textColorSecondary"
+            android:tint="@color/colorAccent"
             app:layout_constraintBottom_toBottomOf="@id/fileBackground"
             app:layout_constraintStart_toStartOf="parent"
             app:layout_constraintTop_toTopOf="@id/fileBackground" />
diff --git a/presentation/src/main/res/layout/mms_vcard_list_item.xml b/presentation/src/main/res/layout/mms_vcard_list_item.xml
index b237b0165..b2b993324 100644
--- a/presentation/src/main/res/layout/mms_vcard_list_item.xml
+++ b/presentation/src/main/res/layout/mms_vcard_list_item.xml
@@ -35,7 +35,7 @@
             android:layout_height="24dp"
             android:layout_marginStart="12dp"
             android:src="@drawable/ic_person_black_24dp"
-            android:tint="?android:attr/textColorSecondary"
+            android:tint="@color/colorAccent"
             app:layout_constraintBottom_toBottomOf="@id/vCardBackground"
             app:layout_constraintStart_toStartOf="parent"
             app:layout_constraintTop_toTopOf="@id/vCardBackground" />
diff --git a/presentation/src/main/res/layout/notification_prefs_activity.xml b/presentation/src/main/res/layout/notification_prefs_activity.xml
index 5f130300d..befb918fc 100644
--- a/presentation/src/main/res/layout/notification_prefs_activity.xml
+++ b/presentation/src/main/res/layout/notification_prefs_activity.xml
@@ -162,7 +162,7 @@
         android:layout_width="match_parent"
         android:layout_height="1dp"
         android:layout_gravity="bottom"
-        android:background="?android:attr/divider"
+        android:background="@color/backgroundDark"
         app:layout_constraintBottom_toBottomOf="parent" />
 
 </androidx.constraintlayout.widget.ConstraintLayout>
\ No newline at end of file
diff --git a/presentation/src/main/res/layout/qksms_plus_activity.xml b/presentation/src/main/res/layout/qksms_plus_activity.xml
index 3045c3670..1d2090fc9 100644
--- a/presentation/src/main/res/layout/qksms_plus_activity.xml
+++ b/presentation/src/main/res/layout/qksms_plus_activity.xml
@@ -260,6 +260,6 @@
         android:layout_width="match_parent"
         android:layout_height="1dp"
         android:layout_gravity="bottom"
-        android:background="?android:attr/divider" />
+        android:background="@color/backgroundDark" />
 
 </androidx.coordinatorlayout.widget.CoordinatorLayout>
\ No newline at end of file
diff --git a/presentation/src/main/res/layout/scheduled_activity.xml b/presentation/src/main/res/layout/scheduled_activity.xml
index 37cbd78c8..79be1d327 100644
--- a/presentation/src/main/res/layout/scheduled_activity.xml
+++ b/presentation/src/main/res/layout/scheduled_activity.xml
@@ -156,6 +156,6 @@
         android:layout_width="match_parent"
         android:layout_height="1dp"
         android:layout_gravity="bottom"
-        android:background="?android:attr/divider" />
+        android:background="@color/backgroundDark" />
 
 </androidx.coordinatorlayout.widget.CoordinatorLayout>
\ No newline at end of file
diff --git a/presentation/src/main/res/values-night/themes.xml b/presentation/src/main/res/values-night/themes.xml
index 79f1dbcfe..a36693d6f 100644
--- a/presentation/src/main/res/values-night/themes.xml
+++ b/presentation/src/main/res/values-night/themes.xml
@@ -17,13 +17,14 @@
   ~ You should have received a copy of the GNU General Public License
   ~ along with QKSMS.  If not, see <http://www.gnu.org/licenses/>.
   -->
-<resources>
+<resources xmlns:tools="http://schemas.android.com/tools">
 
     <style name="AppTheme" parent="AppBaseTheme" />
 
     <style name="AppBaseTheme" parent="Theme.AppCompat.NoActionBar">
         <item name="android:divider">@color/separatorDark</item>
         <item name="android:navigationBarColor">@color/colorPrimaryDark</item>
+        <item name="android:navigationBarDividerColor" tools:targetApi="o_mr1">@color/colorPrimaryDark</item>
         <item name="android:queryBackground">@color/toolbarSearchBackgroundDark</item>
         <item name="android:statusBarColor">@color/statusBarDark</item>
         <item name="android:textColorPrimary">@color/text_primary</item>
@@ -70,6 +71,7 @@
     <!-- Black theme -->
     <style name="AppTheme.Black">
         <item name="android:navigationBarColor">@color/colorPrimaryDark</item>
+        <item name="android:navigationBarDividerColor" tools:targetApi="o_mr1">@color/colorPrimaryDark</item>
         <item name="android:statusBarColor">@color/colorPrimaryDark</item>
         <item name="android:windowBackground">@color/backgroundDark</item>
         <item name="colorPrimary">@color/colorPrimary</item>
diff --git a/presentation/src/main/res/values-v27/themes.xml b/presentation/src/main/res/values-v27/themes.xml
index 3c37e9b56..0dddc369c 100644
--- a/presentation/src/main/res/values-v27/themes.xml
+++ b/presentation/src/main/res/values-v27/themes.xml
@@ -22,6 +22,7 @@
     <!-- On Oreo, use the light status and navigation bars -->
     <style name="AppTheme" parent="AppBaseTheme">
         <item name="android:navigationBarColor">@color/colorPrimaryDark</item>
+        <item name="android:navigationBarDividerColor">@color/colorPrimaryDark</item>
         <item name="android:statusBarColor">@color/statusBarLight</item>
         <item name="android:windowLightNavigationBar">true</item>
         <item name="android:windowLightStatusBar">true</item>
diff --git a/presentation/src/main/res/values/themes.xml b/presentation/src/main/res/values/themes.xml
index 74f5114d6..4ed6f90af 100644
--- a/presentation/src/main/res/values/themes.xml
+++ b/presentation/src/main/res/values/themes.xml
@@ -16,7 +16,7 @@
   ~ You should have received a copy of the GNU General Public License
   ~ along with QKSMS.  If not, see <http://www.gnu.org/licenses/>.
   -->
-<resources>
+<resources xmlns:tools="http://schemas.android.com/tools">
 
     <attr name="bubbleColor" format="reference" />
     <attr name="composeBackground" format="reference" />
@@ -27,6 +27,7 @@
 
     <style name="AppLaunchTheme" parent="Theme.AppCompat.NoActionBar">
         <item name="android:navigationBarColor">@color/colorPrimaryDark</item>
+        <item name="android:navigationBarDividerColor" tools:targetApi="o_mr1">@color/colorPrimaryDark</item>
         <item name="android:statusBarColor">@color/colorPrimaryDark</item>
         <item name="android:windowBackground">@color/backgroundLight</item>
         <item name="android:textCursorDrawable">@drawable/cursor</item>
@@ -59,6 +60,7 @@
         <item name="android:homeAsUpIndicator">@drawable/ic_arrow_back</item>
         <item name="windowActionBar">false</item>
         <item name="android:navigationBarColor">@color/colorPrimaryDark</item>
+        <item name="android:navigationBarDividerColor" tools:targetApi="o_mr1">@color/colorPrimaryDark</item>
         <item name="android:textCursorDrawable">@drawable/cursor</item>
         <item name="alertDialogTheme">@style/customAlertDialog</item>
         <item name="android:alertDialogTheme">@style/customAlertDialog</item>
-- 
GitLab