Remove core-ktx to prevent build failure and remove release signature as... (b10ac729) · Commits · e / os / Message

android-smsmms/build.gradle

+0 −1

Original line number	Diff line number	Diff line
		@@ -37,7 +37,6 @@ android {
		}

		dependencies {
		implementation "androidx.core:core-ktx:$androidx_core_version"
		implementation "com.jakewharton.timber:timber:$timber_version"
		implementation 'com.klinkerapps:logger:1.0.3'
		implementation 'com.squareup.okhttp:okhttp:2.5.0'

+7 −4

Original line number	Diff line number	Diff line
		@@ -21,8 +21,8 @@ import android.content.ContentResolver
		import android.content.Context
		import android.content.Intent
		import android.net.Uri
		import android.os.Bundle
		import android.telephony.SmsManager
		import androidx.core.os.bundleOf
		import com.android.mms.MmsConfig
		import com.android.mms.dom.smil.parser.SmilXmlSerializer
		import com.android.mms.util.DownloadManager
		@@ -122,9 +122,12 @@ class Transaction @JvmOverloads constructor(private val context: Context, settin
		null
		}

		val configOverrides = bundleOf(
		Pair(SmsManager.MMS_CONFIG_GROUP_MMS_ENABLED, true),
		Pair(SmsManager.MMS_CONFIG_MAX_MESSAGE_SIZE, MmsConfig.getMaxMessageSize()))

		// Removed android-ktx bundleOf() function because android-ktx cause build failure with sdk 25
		// TODO: Either use android-ktx or write own bundleOf() function.
		val configOverrides = Bundle()
		configOverrides.putBoolean(SmsManager.MMS_CONFIG_GROUP_MMS_ENABLED, true)
		configOverrides.putInt(SmsManager.MMS_CONFIG_MAX_MESSAGE_SIZE, MmsConfig.getMaxMessageSize())

		MmsConfig.getHttpParams()
		?.takeIf { it.isNotEmpty() }

+0 −12

Original line number	Diff line number	Diff line
		@@ -38,16 +38,11 @@ android {
		buildConfigField "String", "BUGSNAG_API_KEY", "\"${System.getenv("BUGSNAG_API_KEY")}\""
		}

		signingConfigs {
		release
		}

		buildTypes {
		release {
		minifyEnabled true
		shrinkResources true
		proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
		signingConfig signingConfigs.release
		}
		}

		@@ -73,13 +68,6 @@ android {
		universalApk true
		}
		}

		if (System.getenv("CI") == "true") {
		signingConfigs.release.storeFile = file("../keystore")
		signingConfigs.release.storePassword = System.getenv("keystore_password")
		signingConfigs.release.keyAlias = System.getenv("key_alias")
		signingConfigs.release.keyPassword = System.getenv("key_password")
		}
		}

		androidExtensions {