Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f8962a54 authored by fbaron's avatar fbaron
Browse files

Test Week - Add more coverage for Folder.java 

* Refactored Folder class
* 30  methods covered
* Adding more coverage for Folder.java

Bug: 353303621
Test: Not Applicable
Flag: TEST_ONLY
Change-Id: Ibd7ca8c2121ddc71c33f91262b46e593670eadfe
parent 892d3583

src/com/android/launcher3/dragndrop/DragLayer.java

+4 −2
Original line number Diff line number Diff line
@@ -157,7 +157,8 @@ public class DragLayer extends BaseDragLayer<Launcher> implements LauncherOverla 
                        isOverFolderOrSearchBar = isEventOverView(topView, ev) ||

                                isEventOverAccessibleDropTargetBar(ev);

                        if (!isOverFolderOrSearchBar) {

                            sendTapOutsideFolderAccessibilityEvent(currentFolder.isEditingName());

                            sendTapOutsideFolderAccessibilityEvent(

                                    currentFolder.getIsEditingName());

                            mHoverPointClosesFolder = true;

                            return true;

                        }
@@ -167,7 +168,8 @@ public class DragLayer extends BaseDragLayer<Launcher> implements LauncherOverla 
                        isOverFolderOrSearchBar = isEventOverView(topView, ev) ||

                                isEventOverAccessibleDropTargetBar(ev);

                        if (!isOverFolderOrSearchBar && !mHoverPointClosesFolder) {

                            sendTapOutsideFolderAccessibilityEvent(currentFolder.isEditingName());

                            sendTapOutsideFolderAccessibilityEvent(

                                    currentFolder.getIsEditingName());

                            mHoverPointClosesFolder = true;

                            return true;

                        } else if (!isOverFolderOrSearchBar) {

src/com/android/launcher3/folder/Folder.java

+286 −84

File changed.

Preview size limit exceeded, changes collapsed.

src/com/android/launcher3/folder/FolderAnimationManager.java

+3 −3
Original line number Diff line number Diff line
@@ -255,8 +255,8 @@ public class FolderAnimationManager { 
                mFolder.getContent(), contentStart, contentEnd, finalRadius, !mIsOpening));



        // Fade in the folder name, as the text can overlap the icons when grid size is small.

        mFolder.mFolderName.setAlpha(mIsOpening ? 0f : 1f);

        play(a, getAnimator(mFolder.mFolderName, View.ALPHA, 0, 1),

        mFolder.getFolderName().setAlpha(mIsOpening ? 0f : 1f);

        play(a, getAnimator(mFolder.getFolderName(), View.ALPHA, 0, 1),

                mIsOpening ? FOLDER_NAME_ALPHA_DURATION : 0,

                mIsOpening ? mDuration - FOLDER_NAME_ALPHA_DURATION : FOLDER_NAME_ALPHA_DURATION);
@@ -317,7 +317,7 @@ public class FolderAnimationManager { 
                mFolder.mFooter.setScaleX(1f);

                mFolder.mFooter.setScaleY(1f);

                mFolder.mFooter.setTranslationX(0f);

                mFolder.mFolderName.setAlpha(1f);

                mFolder.getFolderName().setAlpha(1f);



                mFolder.setClipChildren(mFolderClipChildren);

                mFolder.setClipToPadding(mFolderClipToPadding);

src/com/android/launcher3/folder/FolderIcon.java

+1 −1
Original line number Diff line number Diff line
@@ -458,7 +458,7 @@ public class FolderIcon extends FrameLayout implements FolderListener, IconLabel 


        mInfo.setTitle(newTitle, mFolder.mLauncherDelegate.getModelWriter());

        onTitleChanged(mInfo.title);

        mFolder.mFolderName.setText(mInfo.title);

        mFolder.getFolderName().setText(mInfo.title);



        // Logging for folder creation flow

        StatsLogManager.newInstance(getContext()).logger()

src/com/android/launcher3/folder/FolderPagedView.java

+2 −2
Original line number Diff line number Diff line
@@ -361,8 +361,8 @@ public class FolderPagedView extends PagedView<PageIndicatorDots> implements Cli 
        // Update footer

        mPageIndicator.setVisibility(getPageCount() > 1 ? View.VISIBLE : View.GONE);

        // Set the gravity as LEFT or RIGHT instead of START, as START depends on the actual text.

        mFolder.mFolderName.setGravity(getPageCount() > 1 ?

                (mIsRtl ? Gravity.RIGHT : Gravity.LEFT) : Gravity.CENTER_HORIZONTAL);

        mFolder.getFolderName().setGravity(getPageCount() > 1

                ? (mIsRtl ? Gravity.RIGHT : Gravity.LEFT) : Gravity.CENTER_HORIZONTAL);

    }



    public int getDesiredWidth() {