Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f6264d23 authored by Nicolo' Mazzucato's avatar Nicolo' Mazzucato Committed by Nicolò Mazzucato
Browse files

Preload overview after unfold 

Before this change, the configChange was processed when launcher becomes visible. However, this happened during animations (e.g. swipe to home after unfold to app).

With this change, the onConfigChange received by TIS (so, it's received also if the activity is not visible), is used to preload overview, moving a ~100ms block to unfold instead of during the animation.

Bug: 294352799
Test: recorded a perfetto trace and checked jank decrease
Change-Id: I35a7036887cc9ea490f27d5ccd47fe423775350b
Merged-In: I35a7036887cc9ea490f27d5ccd47fe423775350b
(cherry picked from commit 11ce5f85)
parent 4c053e5f

quickstep/src/com/android/quickstep/TouchInteractionService.java

+12 −1
Original line number Diff line number Diff line
@@ -28,6 +28,7 @@ import static com.android.launcher3.MotionEventsUtils.isTrackpadMotionEvent; 
import static com.android.launcher3.MotionEventsUtils.isTrackpadMultiFingerSwipe;

import static com.android.launcher3.config.FeatureFlags.ENABLE_TRACKPAD_GESTURE;

import static com.android.launcher3.util.Executors.MAIN_EXECUTOR;

import static com.android.launcher3.util.window.WindowManagerProxy.MIN_TABLET_WIDTH;

import static com.android.quickstep.GestureState.DEFAULT_STATE;

import static com.android.quickstep.GestureState.TrackpadGestureType.getTrackpadGestureType;

import static com.android.quickstep.InputConsumer.TYPE_CURSOR_HOVER;
@@ -68,6 +69,7 @@ import android.os.Bundle; 
import android.os.IBinder;

import android.os.Looper;

import android.os.SystemClock;

import android.os.Trace;

import android.util.Log;

import android.view.Choreographer;

import android.view.InputDevice;
@@ -1210,7 +1212,9 @@ public class TouchInteractionService extends Service { 
    }



    private void preloadOverview(boolean fromInit) {

        Trace.beginSection("preloadOverview(fromInit=" + fromInit + ")");

        preloadOverview(fromInit, false);

        Trace.endSection();

    }



    private void preloadOverview(boolean fromInit, boolean forSUWAllSet) {
@@ -1260,7 +1264,10 @@ public class TouchInteractionService extends Service { 
            // We only care about the existing background activity.

            return;

        }

        if (mOverviewComponentObserver.canHandleConfigChanges(activity.getComponentName(),

        Configuration oldConfig = activity.getResources().getConfiguration();

        boolean isFoldUnfold = isTablet(oldConfig) != isTablet(newConfig);

        if (!isFoldUnfold && mOverviewComponentObserver.canHandleConfigChanges(

                activity.getComponentName(),

                activity.getResources().getConfiguration().diff(newConfig))) {

            // Since navBar gestural height are different between portrait and landscape,

            // can handle orientation changes and refresh navigation gestural region through
@@ -1275,6 +1282,10 @@ public class TouchInteractionService extends Service { 
        preloadOverview(false /* fromInit */);

    }



    private static boolean isTablet(Configuration config) {

        return config.smallestScreenWidthDp >= MIN_TABLET_WIDTH;

    }



    @Override

    protected void dump(FileDescriptor fd, PrintWriter pw, String[] rawArgs) {

        // Dump everything