Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit e0ec0d2a authored by Bruno Martins's avatar Bruno Martins Committed by Michael Bestas
Browse files

RecentsView: Unconditionally hide split option for Go-enabled targets 

Split option should be disabled for Go-enabled targets as seen
in go/quickstep/res/layout/overview_actions_container.xml.
Here's the snippet:

        <!-- Unused. Included only for compatibility with parent class. -->
        <Button
            android:id="@+id/action_split"
            style="@style/GoOverviewActionButton"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:drawableStart="@drawable/ic_split_vertical"
            android:text="@string/action_split"
            android:theme="@style/ThemeControlHighlightWorkspaceColor"
            android:visibility="gone" />

        <Space
            android:id="@+id/action_split_space"
            android:layout_width="0dp"
            android:layout_height="1dp"
            android:layout_weight="1"
            android:visibility="gone" />

Change-Id: I5b0a1c340d86430df8d0e2f2b8e800f3867024e6
parent bb5e7bef

quickstep/src/com/android/quickstep/views/RecentsView.java

+4 −1
Original line number Diff line number Diff line
@@ -76,6 +76,7 @@ import android.animation.PropertyValuesHolder; 
import android.animation.ValueAnimator;

import android.annotation.SuppressLint;

import android.annotation.TargetApi;

import android.app.ActivityManager;

import android.app.WindowConfiguration;

import android.content.Context;

import android.content.Intent;
@@ -3957,13 +3958,15 @@ public abstract class RecentsView<ACTIVITY_TYPE extends StatefulActivity<STATE_T 
     * If actions are showing, we only show split option if

     * * Device is large screen

     * * There are at least 2 tasks to invoke split

     * Unconditionally hide split option for Go-enabled targets

     */

    private void updateCurrentTaskActionsVisibility() {

        boolean isCurrentSplit = getCurrentPageTaskView() instanceof GroupedTaskView;

        mActionsView.updateHiddenFlags(HIDDEN_SPLIT_SCREEN, isCurrentSplit);

        mActionsView.updateHiddenFlags(HIDDEN_SPLIT_SELECT_ACTIVE, isSplitSelectionActive());

        mActionsView.updateSplitButtonHiddenFlags(FLAG_IS_NOT_TABLET,

                !mActivity.getDeviceProfile().isTablet);

                !mActivity.getDeviceProfile().isTablet ||

                getContext().getSystemService(ActivityManager.class).isLowRamDevice());

        mActionsView.updateSplitButtonDisabledFlags(FLAG_SINGLE_TASK, /*enable=*/ false);

        if (DESKTOP_MODE_SUPPORTED) {

            boolean isCurrentDesktop = getCurrentPageTaskView() instanceof DesktopTaskView;