Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d4d704e7 authored by TreeHugger Robot's avatar TreeHugger Robot Committed by Android (Google) Code Review
Browse files

Merge "Adding a utility class to easily track bitmap creations during... 

Merge "Adding a utility class to easily track bitmap creations during View.draw" into ub-launcher3-master
parents 766a5d13 3c431574

iconloaderlib/src/com/android/launcher3/icons/GraphicsUtils.java

+5 −1
Original line number Diff line number Diff line
@@ -30,6 +30,8 @@ public class GraphicsUtils { 


    private static final String TAG = "GraphicsUtils";



    public static Runnable sOnNewBitmapRunnable = () -> { };



    /**

     * Set the alpha component of {@code color} to be {@code alpha}. Unlike the support lib version,

     * it bounds the alpha in valid range instead of throwing an exception to allow for safer
@@ -77,5 +79,7 @@ public class GraphicsUtils { 
    /**

     * Utility method to track new bitmap creation

     */

    public static void noteNewBitmapCreated() { }

    public static void noteNewBitmapCreated() {

        sOnNewBitmapRunnable.run();

    }

}

src/com/android/launcher3/MainProcessInitializer.java

+5 −0
Original line number Diff line number Diff line
@@ -19,6 +19,7 @@ package com.android.launcher3; 
import android.content.Context;



import com.android.launcher3.config.FeatureFlags;

import com.android.launcher3.graphics.BitmapCreationCheck;

import com.android.launcher3.graphics.IconShape;

import com.android.launcher3.logging.FileLog;

import com.android.launcher3.util.ResourceBasedOverride;
@@ -39,5 +40,9 @@ public class MainProcessInitializer implements ResourceBasedOverride { 
        FeatureFlags.initialize(context);

        SessionCommitReceiver.applyDefaultUserPrefs(context);

        IconShape.init(context);



        if (BitmapCreationCheck.ENABLED) {

            BitmapCreationCheck.startTracking(context);

        }

    }

}

src/com/android/launcher3/graphics/BitmapCreationCheck.java

0 → 100644
+118 −0
Original line number Diff line number Diff line 
/*

 * Copyright (C) 2019 The Android Open Source Project

 *

 * Licensed under the Apache License, Version 2.0 (the "License");

 * you may not use this file except in compliance with the License.

 * You may obtain a copy of the License at

 *

 *      http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License.

 */

package com.android.launcher3.graphics;



import android.annotation.TargetApi;

import android.app.Activity;

import android.app.Application;

import android.app.Application.ActivityLifecycleCallbacks;

import android.content.Context;

import android.graphics.Canvas;

import android.os.Build.VERSION_CODES;

import android.os.Bundle;

import android.os.Handler;

import android.util.Log;

import android.view.View;

import android.view.View.OnAttachStateChangeListener;

import android.view.ViewTreeObserver.OnDrawListener;



import com.android.launcher3.Utilities;

import com.android.launcher3.icons.GraphicsUtils;



/**

 * Utility class to check bitmap creation during draw pass.

 */

public class BitmapCreationCheck {



    private static final String TAG = "BitmapCreationCheck";



    public static final boolean ENABLED = false;



    /**

     * Starts tracking bitmap creations during {@link View#draw(Canvas)} calls

     */

    public static void startTracking(Context context) {

        MyTracker tracker = new MyTracker();

        ((Application) context.getApplicationContext()).registerActivityLifecycleCallbacks(tracker);

        GraphicsUtils.sOnNewBitmapRunnable = tracker::onBitmapCreated;

    }



    @TargetApi(VERSION_CODES.Q)

    private static class MyTracker

            implements ActivityLifecycleCallbacks, OnAttachStateChangeListener {



        private final ThreadLocal<Boolean> mCurrentThreadDrawing =

                ThreadLocal.withInitial(() -> false);



        @Override

        public void onActivityCreated(Activity activity, Bundle bundle) {

            activity.getWindow().getDecorView().addOnAttachStateChangeListener(this);

        }



        @Override

        public void onActivityStarted(Activity activity) { }



        @Override

        public void onActivityResumed(Activity activity) { }



        @Override

        public void onActivityPaused(Activity activity) { }



        @Override

        public void onActivityStopped(Activity activity) { }



        @Override

        public void onActivitySaveInstanceState(Activity activity, Bundle bundle) { }



        @Override

        public void onActivityDestroyed(Activity activity) { }



        @Override

        public void onViewAttachedToWindow(View view) {

            view.getViewTreeObserver().addOnDrawListener(new MyViewDrawListener(view.getHandler()));

        }



        @Override

        public void onViewDetachedFromWindow(View view) { }



        private class MyViewDrawListener implements OnDrawListener, Runnable {



            private final Handler mHandler;



            MyViewDrawListener(Handler handler) {

                mHandler = handler;

            }



            @Override

            public void onDraw() {

                mCurrentThreadDrawing.set(true);

                Utilities.postAsyncCallback(mHandler, this);

            }



            @Override

            public void run() {

                mCurrentThreadDrawing.set(false);

            }

        }



        private void onBitmapCreated() {

            if (mCurrentThreadDrawing.get()) {

                Log.e(TAG, "Bitmap created during draw pass", new Exception());

            }

        }

    }



}