Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 06be7eb8 authored by Vinit Nayak's avatar Vinit Nayak Committed by Android (Google) Code Review
Browse files

Revert "Hold WeakReference to split callback" 

This reverts commit 3f5e3ad4.

Reason for revert: b/297562709

Change-Id: I889d126e622e9cf13513365145eac28eaefa8627
parent 3f5e3ad4

quickstep/src/com/android/quickstep/util/SplitSelectStateController.java

+4 −5
Original line number Diff line number Diff line
@@ -101,7 +101,6 @@ import com.android.systemui.shared.system.RemoteAnimationRunnerCompat; 
import com.android.wm.shell.splitscreen.ISplitSelectListener;



import java.io.PrintWriter;

import java.lang.ref.WeakReference;

import java.util.ArrayList;

import java.util.Collections;

import java.util.List;
@@ -568,13 +567,13 @@ public class SplitSelectStateController { 


        private final int mInitialTaskId;

        private final int mSecondTaskId;

        private final WeakReference<Consumer<Boolean>> mSuccessCallback;

        private final Consumer<Boolean> mSuccessCallback;



        RemoteSplitLaunchTransitionRunner(int initialTaskId, int secondTaskId,

                @Nullable Consumer<Boolean> callback) {

            mInitialTaskId = initialTaskId;

            mSecondTaskId = secondTaskId;

            mSuccessCallback = new WeakReference<>(callback);

            mSuccessCallback = callback;

        }



        @Override
@@ -594,8 +593,8 @@ public class SplitSelectStateController { 
                TaskViewUtils.composeRecentsSplitLaunchAnimator(mLaunchingTaskView, mStateManager,

                        mDepthController, mInitialTaskId, mSecondTaskId, info, t, () -> {

                            finishAdapter.run();

                            if (mSuccessCallback.get() != null) {

                                mSuccessCallback.get().accept(true);

                            if (mSuccessCallback != null) {

                                mSuccessCallback.accept(true);

                            }

                            resetState();

                        });