Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 04e2c9ef authored by Tony Wickham's avatar Tony Wickham
Browse files

Stop clearing focus when snapping to a new workspace page. 

Clearing the focus was causing the first child in the new page to
immediately take focus, which caused FocusIndicatorView jank when
using a keyboard.

Bug: 25256728
Change-Id: I5ab31ebc3fe370d7ac9e9792b30dab3467023738
parent 4530aca9

src/com/android/launcher3/FocusHelper.java

+0 −1
Original line number Diff line number Diff line
@@ -397,7 +397,6 @@ public class FocusHelper { 
                if (newIconIndex == FocusLogic.PREVIOUS_PAGE_LEFT_COLUMN) {

                    newPageIndex = pageIndex - 1;

                }

                workspace.snapToPage(newPageIndex);

                row = ((CellLayout.LayoutParams) v.getLayoutParams()).cellY;

                parent = getCellLayoutChildrenForIndex(workspace, newPageIndex);

                if (parent != null) {

src/com/android/launcher3/PagedView.java

+0 −5
Original line number Diff line number Diff line
@@ -2078,11 +2078,6 @@ public abstract class PagedView extends ViewGroup implements ViewGroup.OnHierarc 
        whichPage = validateNewPage(whichPage);



        mNextPage = whichPage;

        View focusedChild = getFocusedChild();

        if (focusedChild != null && whichPage != mCurrentPage &&

                focusedChild == getPageAt(mCurrentPage)) {

            focusedChild.clearFocus();

        }



        pageBeginMoving();

        awakenScrollBars(duration);